Skip to content

Commit 1c473b6

Browse files
committed
Deleted todo, expectedFailure
1 parent 07940cd commit 1c473b6

File tree

5 files changed

+5
-12
lines changed

5 files changed

+5
-12
lines changed

Lib/test/test_enum.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,8 +1002,6 @@ def test_programmatic_function_type_from_subclass_with_start(self):
10021002
self.assertIn(e, SummerMonth)
10031003
self.assertIs(type(e), SummerMonth)
10041004

1005-
# TODO: RUSTPYTHON
1006-
@unittest.expectedFailure
10071005
def test_subclassing(self):
10081006
if isinstance(Name, Exception):
10091007
raise Name

Lib/test/test_pickle.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,9 @@ def test_in_band_buffers(self): # TODO: RUSTPYTHON, remove when this passes
118118
def test_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
119119
super().test_nested_names() # TODO: RUSTPYTHON, remove when this passes
120120

121-
# TODO: RUSTPYTHON, AssertionError
122-
@unittest.expectedFailure
123121
def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
124122
super().test_newobj_generic() # TODO: RUSTPYTHON, remove when this passes
125123

126-
# TODO: RUSTPYTHON, TypeError: cannot pickle 'weakproxy' object
127-
@unittest.expectedFailure
128124
def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
129125
super().test_newobj_proxies() # TODO: RUSTPYTHON, remove when this passes
130126

Lib/test/test_pickletools.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,9 @@ def test_in_band_buffers(self): # TODO: RUSTPYTHON, remove when this passes
4040
def test_nested_names(self): # TODO: RUSTPYTHON, remove when this passes
4141
super().test_nested_names()
4242

43-
# TODO: RUSTPYTHON
44-
@unittest.expectedFailure
4543
def test_newobj_generic(self): # TODO: RUSTPYTHON, remove when this passes
4644
super().test_newobj_generic()
4745

48-
# TODO: RUSTPYTHON, TypeError: cannot pickle 'weakproxy' object
49-
@unittest.expectedFailure
5046
def test_newobj_proxies(self): # TODO: RUSTPYTHON, remove when this passes
5147
super().test_newobj_proxies()
5248

Lib/test/test_unicode.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2392,8 +2392,6 @@ def __iadd__(self, o):
23922392
s += "4"
23932393
self.assertEqual(s, "3")
23942394

2395-
# TODO: RUSTPYTHON
2396-
@unittest.expectedFailure
23972395
def test_getnewargs(self):
23982396
text = 'abc'
23992397
args = text.__getnewargs__()

vm/src/builtins/str.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1258,6 +1258,11 @@ impl PyStr {
12581258
fn encode(zelf: PyRef<Self>, args: EncodeArgs, vm: &VirtualMachine) -> PyResult<PyBytesRef> {
12591259
encode_string(zelf, args.encoding, args.errors, vm)
12601260
}
1261+
1262+
#[pymethod(magic)]
1263+
fn getnewargs(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyObjectRef {
1264+
(zelf.as_str(),).to_pyobject(vm)
1265+
}
12611266
}
12621267

12631268
impl PyStrRef {

0 commit comments

Comments
 (0)