Skip to content

[General] Review Comments Before JOSS Acceptance #795

@giovannifereoli

Description

@giovannifereoli

Guys, wonderful package and a very well-written paper. I just have a few questions/comments before I can give the green light for acceptance to openjournals/joss-reviews#10630.

Mandatory (in my opinion):

  1. Add the Statement of Need as one of the first sections in the documentation.
  2. Explain the testing approach in the documentation.
  3. Explain the testing approach in the paper as well.

Nice to have (personal preference):

  1. Include a small illustrative example in the paper.

Question / concern:

  1. What happens for non-Hamiltonian flows?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions