Merge pull request #499 from contentstack/development

staging PR

Author: harshithad0703

.talismanrc

@@ -9,7 +9,7 @@ fileignoreconfig:
     ignore_detectors:
       - filecontent
   - filename: package-lock.json
-    checksum: 17b5bbabcc58beaa180a7fa931fc3fb407ee0e3447d47da224f60118c0a4c294
+    checksum: 751efa34d2f832c7b99771568b5125d929dab095784b6e4ea659daaa612994c8
   - filename: .husky/pre-commit
     checksum: 52a664f536cf5d1be0bea19cb6031ca6e8107b45b6314fe7d47b7fad7d800632
   - filename: test/sanity-check/api/user-test.js
@@ -34,7 +34,10 @@ fileignoreconfig:
     checksum: 4043efd843e24da9afd0272c55ef4b0432e3374b2ca12b913f1a6654df3f62be
   - filename: test/unit/contentstack-test.js
     checksum: 2597efae3c1ab8cc173d5bf205f1c76932211f8e0eb2a16444e055d83481976c
+  - filename: test/unit/concurrency-Queue-test.js
+    checksum: 186438f9eb9ba4e7fd7f335dbea2afbae9ae969b7ae3ab1b517ec7a1633d255e
 version: "1.0"
 
 
 
+

CHANGELOG.md

@@ -1,8 +1,13 @@
 # Changelog
 
-## [v1.27.3](https://github.com/contentstack/contentstack-management-javascript/tree/v1.27.3) (2026-02-02)
+## [v1.27.4](https://github.com/contentstack/contentstack-management-javascript/tree/v1.27.4) (2026-02-02)
  - Fix
    - Removed content-type header from the release delete method
+   - Plugin `onResponse` hook is now called for error responses; errors handled by the concurrency queue (e.g. 5xx, retries exhausted) were previously not running plugin hooks
+
+## [v1.27.3](https://github.com/contentstack/contentstack-management-javascript/tree/v1.27.3) (2026-01-21)
+ - Fix
+   - Skip token refresh and preserve error_code 294 when 2FA is required (error_code 294 with 401 status) to prevent error code conversion from 294 to 401
 
 ## [v1.27.2](https://github.com/contentstack/contentstack-management-javascript/tree/v1.27.2) (2026-01-12)
  - Enhancement

lib/core/concurrency-queue.js

@@ -52,7 +52,7 @@ const defaultConfig = {
  * @returns {Object} ConcurrencyQueue instance with request/response interceptors attached to Axios.
  * @throws {Error} If axios instance is not provided or configuration is invalid.
  */
-export function ConcurrencyQueue ({ axios, config }) {
+export function ConcurrencyQueue ({ axios, config, plugins = [] }) {
   if (!axios) {
     throw Error(ERROR_MESSAGES.AXIOS_INSTANCE_MISSING)
   }
@@ -436,6 +436,30 @@ export function ConcurrencyQueue ({ axios, config }) {
     return response
   }
 
+  // Run plugin onResponse hooks for errors so plugins see every error (including
+  // those that are rejected without going through the plugin response interceptor).
+  const runPluginOnResponseForError = (error) => {
+    if (!plugins || !plugins.length) return error
+    let currentError = error
+    for (const plugin of plugins) {
+      try {
+        if (typeof plugin.onResponse === 'function') {
+          const result = plugin.onResponse(currentError)
+          if (result !== undefined) currentError = result
+        }
+      } catch (e) {
+        if (this.config.logHandler) {
+          this.config.logHandler('error', {
+            name: 'PluginError',
+            message: `Error in plugin onResponse (error handler): ${e.message}`,
+            error: e
+          })
+        }
+      }
+    }
+    return currentError
+  }
+
   const responseErrorHandler = error => {
     let networkError = error.config.retryCount
     let retryErrorType = null
@@ -449,7 +473,8 @@ export function ConcurrencyQueue ({ axios, config }) {
 
     // Original retry logic for non-network errors
     if (!this.config.retryOnError || networkError > this.config.retryLimit) {
-      return Promise.reject(responseHandler(error))
+      const err = runPluginOnResponseForError(error)
+      return Promise.reject(responseHandler(err))
     }
 
     // Check rate limit remaining header before retrying
@@ -465,14 +490,23 @@ export function ConcurrencyQueue ({ axios, config }) {
         }
         response = error.response
       } else {
-        return Promise.reject(responseHandler(error))
+        const err = runPluginOnResponseForError(error)
+        return Promise.reject(responseHandler(err))
       }
     } else if ((response.status === 401 && this.config.refreshToken)) {
+      // If error_code is 294 (2FA required), don't retry/refresh - pass through the error as-is
+      const apiErrorCode = response.data?.error_code
+      if (apiErrorCode === 294) {
+        const err = runPluginOnResponseForError(error)
+        return Promise.reject(responseHandler(err))
+      }
+
       retryErrorType = `Error with status: ${response.status}`
       networkError++
 
       if (networkError > this.config.retryLimit) {
-        return Promise.reject(responseHandler(error))
+        const err = runPluginOnResponseForError(error)
+        return Promise.reject(responseHandler(err))
       }
       this.running.shift()
       // Cool down the running requests
@@ -486,19 +520,22 @@ export function ConcurrencyQueue ({ axios, config }) {
       networkError++
       return this.retry(error, retryErrorType, networkError, wait)
     }
-    return Promise.reject(responseHandler(error))
+    const err = runPluginOnResponseForError(error)
+    return Promise.reject(responseHandler(err))
   }
 
   this.retry = (error, retryErrorType, retryCount, waittime) => {
     let delaytime = waittime
     if (retryCount > this.config.retryLimit) {
-      return Promise.reject(responseHandler(error))
+      const err = runPluginOnResponseForError(error)
+      return Promise.reject(responseHandler(err))
     }
     if (this.config.retryDelayOptions) {
       if (this.config.retryDelayOptions.customBackoff) {
         delaytime = this.config.retryDelayOptions.customBackoff(retryCount, error)
         if (delaytime && delaytime <= 0) {
-          return Promise.reject(responseHandler(error))
+          const err = runPluginOnResponseForError(error)
+          return Promise.reject(responseHandler(err))
         }
       } else if (this.config.retryDelayOptions.base) {
         delaytime = this.config.retryDelayOptions.base * retryCount

lib/core/contentstackHTTPClient.js

@@ -109,10 +109,11 @@ export default function contentstackHttpClient (options) {
   }
   const instance = axios.create(axiosOptions)
   instance.httpClientParams = options
-  instance.concurrencyQueue = new ConcurrencyQueue({ axios: instance, config })
 
-  // Normalize and store plugins
-  const plugins = normalizePlugins(config.plugins)
+  // Normalize and store plugins before ConcurrencyQueue so plugin interceptors
+  // run after the queue's (plugin sees responses/errors before they reach the queue).
+  // Use options.plugins so hooks run against the same plugin references (spies work in tests).
+  const plugins = normalizePlugins(options.plugins || config.plugins)
 
   // Request interceptor for versioning strategy (must run first)
   instance.interceptors.request.use((request) => {
@@ -235,5 +236,7 @@ export default function contentstackHttpClient (options) {
     )
   }
 
+  instance.concurrencyQueue = new ConcurrencyQueue({ axios: instance, config, plugins })
+
   return instance
 }