Skip to content

Commit 4318d76

Browse files
committed
Release test case
1 parent 5934157 commit 4318d76

2 files changed

Lines changed: 9 additions & 26 deletions

File tree

lib/stack/release/index.js

Lines changed: 5 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export function Release (http, data = {}) {
2121
if (data.release) {
2222
Object.assign(this, cloneDeep(data.release))
2323
if (data.release.items) {
24-
this.items = new ReleaseItemCollection(http, data.release, this.uid)
24+
this.items = new ReleaseItemCollection(http, { items: data.release.items, stackHeaders: data.stackHeaders }, this.uid)
2525
}
2626
this.urlPath = `/releases/${this.uid}`
2727
/**
@@ -140,19 +140,7 @@ export function Release (http, data = {}) {
140140
* .then((notice) => console.log(notice))
141141
*/
142142
this.deploy = async ({ environments, locales, scheduledAt, action }) => {
143-
var release = {}
144-
if (environments) {
145-
release.environments = environments
146-
}
147-
if (locales) {
148-
release.locales = locales
149-
}
150-
if (scheduledAt) {
151-
release.scheduled_at = scheduledAt
152-
}
153-
if (action) {
154-
release.action = action
155-
}
143+
var release = { environments, locales, scheduledAt, action }
156144
const headers = {
157145
headers: {
158146
...cloneDeep(this.stackHeaders)
@@ -186,13 +174,8 @@ export function Release (http, data = {}) {
186174
*
187175
*/
188176
this.clone = async ({ name, description }) => {
189-
var release = {}
190-
if (name) {
191-
release.name = name
192-
}
193-
if (description) {
194-
release.description = description
195-
}
177+
var release = { name, description}
178+
196179
const headers = {
197180
headers: {
198181
...cloneDeep(this.stackHeaders)
@@ -255,7 +238,7 @@ export function Release (http, data = {}) {
255238
}
256239

257240
export function ReleaseCollection (http, data) {
258-
const obj = cloneDeep(data.releases)
241+
const obj = cloneDeep(data.releases) || []
259242
const releaseCollection = obj.map((userdata) => {
260243
return new Release(http, { release: userdata, stackHeaders: data.stackHeaders })
261244
})

lib/stack/release/items/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export function ReleaseItem (http, data = {}) {
141141

142142
const response = await http.get(this.urlPath, headers)
143143
if (response.data) {
144-
console.log(response.data)
144+
return ReleaseItemCollection(http, response.data, this.releaseUID)
145145
} else {
146146
throw error(response)
147147
}
@@ -154,10 +154,10 @@ export function ReleaseItem (http, data = {}) {
154154
return this
155155
}
156156

157-
export function ReleaseItemCollection (http, data, releaseUID) {
158-
const obj = cloneDeep(data.items)
157+
export function ReleaseItemCollection (http, data, releaseUid) {
158+
const obj = cloneDeep(data.items) || []
159159
const contentTypeCollection = obj.map((userdata) => {
160-
return new ReleaseItem(http, { releaseUID: releaseUID, item: userdata, stackHeaders: data.stackHeaders })
160+
return new ReleaseItem(http, { releaseUid, item: userdata, stackHeaders: data.stackHeaders })
161161
})
162162
return contentTypeCollection
163163
}

0 commit comments

Comments
 (0)