resolving eslint issues

Author: michaeled

.eslintrc

@@ -5,6 +5,7 @@
     ],
     "rules": {
       "unicorn/no-abusive-eslint-disable": "off",
-      "@typescript-eslint/no-use-before-define": "off"
+      "@typescript-eslint/no-use-before-define": "off",
+      "@typescript-eslint/ban-ts-ignore": "off"
     }
   }

src/commands/content-type/compare.ts

@@ -51,8 +51,7 @@ export default class CompareCommand extends Command {
       const {flags} = this.parse(CompareCommand)
       this.setup(flags)
 
-      const [stack, previous, current] = await Promise.all
-      ([
+      const [stack, previous, current] = await Promise.all([
         this.client.getStack(this.apiKey),
         this.client.getContentType(this.apiKey, flags['content-type'], true, flags.left),
         this.client.getContentType(this.apiKey, flags['content-type'], true, flags.right),

src/commands/content-type/details.ts

@@ -37,8 +37,7 @@ export default class DetailsCommand extends Command {
       const {flags} = this.parse(DetailsCommand)
       this.setup(flags)
 
-      const [stack, contentType, references] = await Promise.all
-      ([
+      const [stack, contentType, references] = await Promise.all([
         this.client.getStack(this.apiKey),
         this.client.getContentType(this.apiKey, flags['content-type'], true),
         this.client.getContentTypeReferences(this.apiKey, flags['content-type']),

src/core/content-type/compare.ts

@@ -15,7 +15,7 @@ export default async function buildOutput(contentTypeName: string, previous: any
     matching: 'lines',
   })
 
-  await tmp.file({prefix: `${contentTypeName}-compare`, postfix: '.html', keep: true}, async function (err: any, path: any, fd: any, cleanupCallback: any) {
+  await tmp.file({prefix: `${contentTypeName}-compare`, postfix: '.html', keep: true}, async function (err: any, path: any, _fd: any, _cleanupCallback: any) {
     if (err) throw err
     fs.writeFileSync(path, html(diffHtml))
     await cli.open(path)

src/core/content-type/details.ts

@@ -49,7 +49,7 @@ function processFields(schema: any, parent = null, depth = 0, prefix = ''): any
 }
 
 function buildRow(field: any, parent = null, depth = 0, prefix = '') {
-  const dots = '.'.repeat(depth == 0 ? 0 : depth * 2)
+  const dots = '.'.repeat(depth === 0 ? 0 : depth * 2)
   const displayName = `${prefix ? dots : ''}${parent ? '[' + parent + '] ' : ''}${field.display_name}`
   const path = `${prefix ? prefix + '.' : ''}${field.uid}`
 
@@ -69,7 +69,7 @@ function buildHeader(contentType: any, references: string[]) {
   const details = []
 
   result.push(`Description: ${contentType.description ? contentType.description : 'None'}`)
-  result.push(`Referenced By: ${references.length ? references.join(', ') : 'None'}\n`)
+  result.push(`Referenced By: ${references.length > 0 ? references.join(', ') : 'None'}\n`)
 
   details.push(['Type', 'Multiple', 'URL Pattern', 'Created', 'Modified', 'Version'])
 

src/core/content-type/formatting.ts

@@ -8,8 +8,8 @@ export function date(date: any) {
 }
 
 export function fullName(users: any, uid: string) {
-  if (!users || users.length == 0) return 'Unknown'
-  const user = users.find((u: any) => u.uid == uid)
+  if (!users || users.length === 0) return 'Unknown'
+  const user = users.find((u: any) => u.uid === uid)
   if (!user) return 'Unknown'
   return `${user.first_name} ${user.last_name}`
 }