refactor(version): separate error handling for the version command (--tag/--major/--minor) and their test cases

Author: yjaw

commitizen/commands/version.py

@@ -72,14 +72,14 @@ def __call__(self) -> None:
             )
             return
 
-        if (
-            self.arguments.get("major")
-            or self.arguments.get("minor")
-            or self.arguments.get("tag")
-        ):
-            out.error(
-                "Major or minor or tag can only be used with --project or --verbose."
-            )
+        if self.arguments.get("major"):
+            out.error("Major can only be used with --project or --verbose.")
+            return
+        if self.arguments.get("minor"):
+            out.error("Minor can only be used with --project or --verbose.")
+            return
+        if self.arguments.get("tag"):
+            out.error("Tag can only be used with --project or --verbose.")
             return
 
         # If no arguments are provided, just show the installed commitizen version

tests/commands/test_version_command.py

@@ -147,20 +147,43 @@ def test_version_just_minor(config, capsys, version: str, expected_version: str)
     assert expected_version == captured.out
 
 
-@pytest.mark.parametrize("argument", ("major", "minor"))
-def test_version_just_major_error_no_project(config, capsys, argument: str):
+def test_version_major_error_no_project(config, capsys):
+    """Test --major requires --project or --verbose"""
     commands.Version(
         config,
         {
-            argument: True,  # type: ignore[misc]
+            "major": True,
         },
     )()
     captured = capsys.readouterr()
     assert not captured.out
-    assert (
-        "Major or minor or tag can only be used with --project or --verbose."
-        in captured.err
-    )
+    assert "Major can only be used with --project or --verbose." in captured.err
+
+
+def test_version_minor_error_no_project(config, capsys):
+    """Test --minor requires --project or --verbose"""
+    commands.Version(
+        config,
+        {
+            "minor": True,
+        },
+    )()
+    captured = capsys.readouterr()
+    assert not captured.out
+    assert "Minor can only be used with --project or --verbose." in captured.err
+
+
+def test_version_tag_error_no_project(config, capsys):
+    """Test --tag requires --project or --verbose"""
+    commands.Version(
+        config,
+        {
+            "tag": True,
+        },
+    )()
+    captured = capsys.readouterr()
+    assert not captured.out
+    assert "Tag can only be used with --project or --verbose." in captured.err
 
 
 @pytest.mark.parametrize(
@@ -187,19 +210,3 @@ def test_version_with_tag_format(
     )()
     captured = capsys.readouterr()
     assert captured.out == expected_output
-
-
-def test_version_tag_without_project_error(config, capsys):
-    """Test --tag requires --project or --verbose"""
-    commands.Version(
-        config,
-        {
-            "tag": True,
-        },
-    )()
-    captured = capsys.readouterr()
-    assert not captured.out
-    assert (
-        "Major or minor or tag can only be used with --project or --verbose."
-        in captured.err
-    )