refactor(Commit): Added deprecation on git signoff mechanic

SCrocky · Lee-W · commit 069fbb73b9aa · 2023-10-17T21:24:25.000+08:00
Signoff dedicated code is no longer necessary &amp; removed #TODO as tests show identical args and extra-args are not an issue.
diff --git a/commitizen/cli.py b/commitizen/cli.py
@@ -465,7 +465,6 @@ def main():
             raise InvalidCommandArgumentError(
                 f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
             )
-        # TODO: treat case when extra-args and commitizen args are identical
         extra_args = " ".join(unknown_args[1:])
         arguments["extra_cli_args"] = extra_args
 
diff --git a/commitizen/commands/commit.py b/commitizen/commands/commit.py
@@ -98,6 +98,7 @@ def __call__(self):
         )
 
         if signoff:
+            out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
             c = git.commit(m, "-s")
 
         if self.arguments.get("extra_cli_args"):

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,6 @@ def main():`
`465`	`465`	`raise InvalidCommandArgumentError(`
`466`	`466`	f"Invalid commitizen arguments were found before -- separator: `{' '.join(unknown_args[:pos])}`. "
`467`	`467`	`)`
`468`		`- # TODO: treat case when extra-args and commitizen args are identical`
`469`	`468`	`extra_args = " ".join(unknown_args[1:])`
`470`	`469`	`arguments["extra_cli_args"] = extra_args`
`471`	`470`
Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,7 @@ def __call__(self):`
`98`	`98`	`)`
`99`	`99`
`100`	`100`	`if signoff:`
	`101`	+ out.warn("signoff mechanic is deprecated, please use `cz commit -- -s` instead.")
`101`	`102`	`c = git.commit(m, "-s")`
`102`	`103`
`103`	`104`	`if self.arguments.get("extra_cli_args"):`