Skip to content

Commit 6df1759

Browse files
committed
feat: Renamed reporter method to promptUserForParameterValues
1 parent 15aa83d commit 6df1759

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

src/orchestrators/import.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export class ImportOrchestrator {
4949
await ImportOrchestrator.validate(typeIds, project, pluginManager, dependencyMap)
5050

5151
const requiredParameters = await pluginManager.getRequiredParameters(typeIds);
52-
const userSuppliedParameters = await reporter.askRequiredParametersForImport(requiredParameters);
52+
const userSuppliedParameters = await reporter.promptUserForParameterValues(requiredParameters);
5353

5454
const importResult = await ImportOrchestrator.getImportedConfigs(pluginManager, typeIds, userSuppliedParameters)
5555

src/ui/reporters/debug-reporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class DebugReporter implements Reporter {
2727
ctx.on(Event.SUB_PROCESS_FINISH, (name) => debug(name))
2828
}
2929

30-
async askRequiredParametersForImport(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
30+
async promptUserForParameterValues(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
3131
if (requiredParameters.size > 0 || [...requiredParameters.values()].reduce(
3232
(total, arr) => arr.length + total, 0
3333
)) {

src/ui/reporters/default-reporter.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export class DefaultReporter implements Reporter {
4444
ctx.on(Event.SUB_PROCESS_FINISH, (name, additionalName) => this.onSubprocessFinishEvent(name, additionalName))
4545
}
4646

47-
async askRequiredParametersForImport(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
47+
async promptUserForParameterValues(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
4848
if (requiredParameters.size === 0) {
4949
return new Map();
5050
}

src/ui/reporters/plain-reporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class PlainReporter implements Reporter {
2020
ctx.on(Event.SUB_PROCESS_FINISH, (name) => console.log(name))
2121
}
2222

23-
async askRequiredParametersForImport(
23+
async promptUserForParameterValues(
2424
requiredParameters: RequiredParameters
2525
): Promise<UserSuppliedParameters> {
2626
if (requiredParameters.size > 0 || [...requiredParameters.values()].reduce(

src/ui/reporters/reporter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ export interface Reporter {
4848
promptConfirmation(message: string): Promise<boolean>
4949

5050
promptSudo(pluginName: string, data: SudoRequestData, secureMode: boolean): Promise<SudoRequestResponseData>;
51-
52-
askRequiredParametersForImport(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters>;
51+
52+
promptUserForParameterValues(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters>;
5353

5454
displayImportResult(importResult: ImportResult): void;
5555
}

test/orchestrator/import/import.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('Import orchestrator tests', () => {
7373
}
7474
});
7575

76-
const askRequiredParametersSpy = vi.spyOn(reporter, 'askRequiredParametersForImport');
76+
const askRequiredParametersSpy = vi.spyOn(reporter, 'promptUserForParameterValues');
7777
const displayImportResultSpy = vi.spyOn(reporter, 'displayImportResult');
7878

7979
MockOs.create('mock', {

test/orchestrator/mocks/reporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class MockReporter implements Reporter {
4242
}
4343
}
4444

45-
async askRequiredParametersForImport(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
45+
async promptUserForParameterValues(requiredParameters: RequiredParameters): Promise<UserSuppliedParameters> {
4646
if (this.config?.askRequiredParametersForImport) {
4747
return this.config.askRequiredParametersForImport(requiredParameters);
4848
}

0 commit comments

Comments
 (0)