feat: Used the reverse transformation to alter the import output to match a user's config + added tests

Author: kevinwang5658

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codify-plugin-lib",
-  "version": "1.0.133",
+  "version": "1.0.135",
   "description": "Library plugin library",
   "main": "dist/index.js",
   "typings": "dist/index.d.ts",

src/resource/parsed-resource-settings.ts

@@ -5,6 +5,7 @@ import { StatefulParameterController } from '../stateful-parameter/stateful-para
 import {
   ArrayParameterSetting,
   DefaultParameterSetting,
+  InputTransformation,
   ParameterSetting,
   resolveElementEqualsFn,
   resolveEqualsFn,
@@ -136,7 +137,7 @@ export class ParsedResourceSettings<T extends StringIndexedObject> implements Re
     });
   }
 
-  get inputTransformations(): Partial<Record<keyof T, (a: unknown, parameter: ParameterSetting) => unknown>> {
+  get inputTransformations(): Partial<Record<keyof T, InputTransformation>> {
     return this.getFromCacheOrCreate('inputTransformations', () => {
       if (!this.settings.parameterSettings) {
         return {};
@@ -145,8 +146,8 @@ export class ParsedResourceSettings<T extends StringIndexedObject> implements Re
       return Object.fromEntries(
         Object.entries(this.settings.parameterSettings)
           .filter(([_, v]) => resolveParameterTransformFn(v!) !== undefined)
-          .map(([k, v]) => [k, resolveParameterTransformFn(v!)!.to] as const)
-      ) as Record<keyof T, (a: unknown) => unknown>;
+          .map(([k, v]) => [k, resolveParameterTransformFn(v!)] as const)
+      ) as Record<keyof T, InputTransformation>;
     });
   }
 

src/resource/resource-controller.test.ts

@@ -535,4 +535,88 @@ describe('Resource tests', () => {
     expect(parameter1.modify.calledOnce).to.be.true;
     expect(parameter2.addItem.calledOnce).to.be.true;
   });
+
+  it('Applies reverse input transformations for imports', async () => {
+    const resource = new class extends TestResource {
+      getSettings(): ResourceSettings<TestConfig> {
+        return {
+          id: 'resourceType',
+          parameterSettings: {
+            propD: {
+              type: 'array',
+              inputTransformation: {
+                to: (hosts: Record<string, unknown>[]) => hosts.map((h) => Object.fromEntries(
+                    Object.entries(h)
+                      .map(([k, v]) => [
+                        k,
+                        typeof v === 'boolean'
+                          ? (v ? 'yes' : 'no') // The file takes 'yes' or 'no' instead of booleans
+                          : v,
+                      ])
+                  )
+                ),
+                from: (hosts: Record<string, unknown>[]) => hosts.map((h) => Object.fromEntries(
+                  Object.entries(h)
+                    .map(([k, v]) => [
+                      k,
+                      v === 'yes' || v === 'no'
+                        ? (v === 'yes')
+                        : v,
+                    ])
+                ))
+              }
+            }
+          }
+        }
+      }
+
+      async refresh(parameters: Partial<TestConfig>): Promise<Partial<TestConfig> | null> {
+        return {
+          propD: [
+            {
+              Host: 'new.com',
+              AddKeysToAgent: true,
+              IdentityFile: 'id_ed25519'
+            },
+            {
+              Host: 'github.com',
+              AddKeysToAgent: true,
+              UseKeychain: true,
+            },
+            {
+              Match: 'User bob,joe,phil',
+              PasswordAuthentication: true,
+            }
+          ],
+        }
+      }
+    }
+
+    const controller = new ResourceController(resource);
+    const plan = await controller.import({ type: 'resourceType' }, {});
+
+    expect(plan![0]).toMatchObject({
+      'core': {
+        'type': 'resourceType'
+      },
+      'parameters': {
+        'propD': [
+          {
+            'Host': 'new.com',
+            'AddKeysToAgent': true,
+            'IdentityFile': 'id_ed25519'
+          },
+          {
+            'Host': 'github.com',
+            'AddKeysToAgent': true,
+            'UseKeychain': true
+          },
+          {
+            'Match': 'User bob,joe,phil',
+            'PasswordAuthentication': true
+          }
+        ]
+      }
+    })
+  })
 });

src/resource/resource-controller.ts

@@ -254,7 +254,10 @@ export class ResourceController<T extends StringIndexedObject> {
     }
 
     const statefulCurrentParameters = await this.refreshStatefulParameters(allStatefulParameters, parametersToRefresh);
-    return [{ core, parameters: { ...currentParametersArray[0], ...statefulCurrentParameters } }];
+    const resultParameters = { ...currentParametersArray[0], ...statefulCurrentParameters };
+
+    await this.applyTransformParameters(resultParameters, true);
+    return [{ core, parameters: resultParameters }];
   }
 
   private async applyCreate(plan: Plan<T>): Promise<void> {
@@ -333,7 +336,7 @@ ${JSON.stringify(refresh, null, 2)}
     }
   }
 
-  private async applyTransformParameters(config: Partial<T> | null): Promise<void> {
+  private async applyTransformParameters(config: Partial<T> | null, reverse = false): Promise<void> {
     if (!config) {
       return;
     }
@@ -343,7 +346,9 @@ ${JSON.stringify(refresh, null, 2)}
         continue;
       }
 
-      (config as Record<string, unknown>)[key] = await inputTransformation(config[key], this.settings.parameterSettings![key]!);
+      (config as Record<string, unknown>)[key] = reverse
+        ? await inputTransformation.from(config[key])
+        : await inputTransformation.to(config[key]);
     }
 
     if (this.settings.inputTransformation) {