Skip to content
This repository was archived by the owner on Dec 8, 2022. It is now read-only.

Commit 4694b5f

Browse files
fix SuccessModal messages after voting, social media links
1 parent fe3f715 commit 4694b5f

File tree

2 files changed

+24
-15
lines changed

2 files changed

+24
-15
lines changed

src/views/Voting/CodeModal.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
</v-card>
7171
</v-dialog>
7272

73-
<success-modal v-model="showSuccess" />
73+
<SuccessModal v-model="showSuccess" />
7474

7575
<v-dialog v-model="showError" max-width="600">
7676
<v-card color="white" light v-if="isOpen">
@@ -210,6 +210,8 @@ export default {
210210
return;
211211
}
212212
this.isSubmitting = true;
213+
this.successMessage = "";
214+
213215
if (!this.fields.email.value) {
214216
this.errorMessage = "You forgot to tell us your email";
215217
this.showError = true;

src/views/Voting/SuccessModal.vue

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,10 @@
55
<v-spacer />
66
<v-btn icon x-large @click="show = false">X</v-btn></v-card-title
77
>
8-
9-
<div v-if="User.isAuthorized">
10-
<h3>SUCCESS!</h3>
8+
<div>
9+
<h3>ALMOST DONE!</h3>
1110

1211
<p style="text-align:center">
13-
Your vote has been cast!
14-
</p>
15-
</div>
16-
<div v-else>
17-
<h3>ALMOST DONE</h3>
18-
19-
<p>
2012
Your vote has been cast! In order for your vote to count you must
2113
first confirm it. Please check your inbox for the confirmation email.
2214
</p>
@@ -27,15 +19,27 @@
2719
</h4>
2820

2921
<v-card-text class="text-center">
30-
<v-btn icon class="mr-6" x-large color="cwhqBlue"
22+
<v-btn
23+
icon
24+
class="mr-6"
25+
x-large
26+
color="cwhqBlue"
27+
href="http://www.facebook.com"
28+
target="_blank"
3129
><v-icon>mdi-facebook</v-icon></v-btn
3230
>
33-
<v-btn icon class="mr-6" x-large color="cwhqBlue"
31+
<v-btn
32+
icon
33+
class="mr-6"
34+
x-large
35+
color="cwhqBlue"
36+
href="http://www.twitter.com"
37+
target="_blank"
3438
><v-icon>mdi-twitter</v-icon></v-btn
3539
>
36-
<v-btn icon class="mr-6" x-large color="cwhqBlue"
40+
<!-- <v-btn icon class="mr-6" x-large color="cwhqBlue"
3741
><v-icon>mdi-email</v-icon></v-btn
38-
>
42+
> -->
3943
</v-card-text>
4044
<br />
4145
</v-card>
@@ -45,6 +49,7 @@
4549
<script>
4650
import { User } from "@/store";
4751
export default {
52+
// TODO: all props should be validated
4853
props: ["value"],
4954
computed: {
5055
...User.mapState()
@@ -55,6 +60,8 @@ export default {
5560
this.$emit("input", this.show);
5661
}
5762
},
63+
// TODO: looks like this used to have a default and an ovveride but was removed
64+
// should implement this
5865
value() {
5966
if (this.show != this.value) {
6067
this.show = this.value;

0 commit comments

Comments
 (0)