🤖 fix: avoid emitting events into disposed sessions

Author: ammar-agent

src/node/services/ExtensionMetadataService.ts

@@ -91,6 +91,13 @@ export class ExtensionMetadataService {
       const content = JSON.stringify(data, null, 2);
       await writeFileAtomic(this.filePath, content, "utf-8");
     } catch (error) {
+      const err = error as NodeJS.ErrnoException;
+      // In Jest/browser harness runs we frequently use a temporary config dir that can be
+      // deleted as soon as a test finishes. Ignore ENOENT to avoid noisy "Cannot log after
+      // tests are done" warnings.
+      if (process.env.NODE_ENV === "test" && err.code === "ENOENT") {
+        return;
+      }
       log.error("Failed to save metadata:", error);
     }
   }

src/node/services/agentSession.ts

@@ -169,17 +169,19 @@ export class AgentSession {
     if (this.disposed) {
       return;
     }
+    // Detach listeners first so stopStream() can't emit events into a disposed session.
+    for (const { event, handler } of this.aiListeners) {
+      this.aiService.off(event, handler as never);
+    }
+    this.aiListeners.length = 0;
+
     this.disposed = true;
 
     // Stop any active stream (fire and forget - disposal shouldn't block)
     void this.aiService.stopStream(this.workspaceId, { abandonPartial: true });
     // Terminate background processes for this workspace
     void this.backgroundProcessManager.cleanup(this.workspaceId);
 
-    for (const { event, handler } of this.aiListeners) {
-      this.aiService.off(event, handler as never);
-    }
-    this.aiListeners.length = 0;
     for (const { event, handler } of this.initListeners) {
       this.initStateManager.off(event, handler as never);
     }