🤖 fix: keep runtime exec helpers resilient to spawn errors

Author: ammar-agent

src/node/runtime/LocalBaseRuntime.ts

@@ -63,14 +63,25 @@ export abstract class LocalBaseRuntime implements Runtime {
       );
     }
 
-    // If niceness is specified on Unix/Linux, spawn nice directly to avoid escaping issues
-    // Windows doesn't have nice command, so just spawn bash directly
+    // If niceness is specified on Unix/Linux, try to spawn `nice` directly to avoid
+    // escaping issues. Some minimal environments may not have `nice` on PATH, so
+    // fall back to running bash directly.
     const isWindows = process.platform === "win32";
     const bashPath = getBashPath();
-    const spawnCommand = options.niceness !== undefined && !isWindows ? "nice" : bashPath;
+
+    const shouldNice = options.niceness !== undefined && !isWindows;
+    const nicePath = shouldNice
+      ? fs.existsSync("/usr/bin/nice")
+        ? "/usr/bin/nice"
+        : fs.existsSync("/bin/nice")
+          ? "/bin/nice"
+          : null
+      : null;
+
+    const spawnCommand = nicePath ?? bashPath;
     const spawnArgs =
-      options.niceness !== undefined && !isWindows
-        ? ["-n", options.niceness.toString(), bashPath, "-c", command]
+      nicePath !== null
+        ? ["-n", options.niceness!.toString(), bashPath, "-c", command]
         : ["-c", command];
 
     const childProcess = spawn(spawnCommand, spawnArgs, {
@@ -145,7 +156,12 @@ export abstract class LocalBaseRuntime implements Runtime {
       });
     });
 
-    const duration = exitCode.then(() => performance.now() - startTime);
+    // Always resolve duration even if exitCode rejects (e.g. spawn errors).
+    // Consumers frequently ignore duration; rejecting would surface as an unhandled rejection.
+    const duration = exitCode.then(
+      () => performance.now() - startTime,
+      () => performance.now() - startTime
+    );
 
     // Register process group cleanup with DisposableProcess
     // This ensures ALL background children are killed when process exits
@@ -175,8 +191,13 @@ export abstract class LocalBaseRuntime implements Runtime {
         disposable[Symbol.dispose](); // Kill process and run cleanup
       }, options.timeout * 1000);
 
-      // Clear timeout if process exits naturally
-      void exitCode.finally(() => clearTimeout(timeoutHandle));
+      // Clear timeout if process exits naturally.
+      // Swallow rejections to avoid unhandled promise noise on spawn errors.
+      exitCode
+        .finally(() => clearTimeout(timeoutHandle))
+        .catch(() => {
+          /* ignore */
+        });
     }
 
     return { stdout, stderr, stdin, exitCode, duration };

tests/browser/harness/env.ts

@@ -89,6 +89,7 @@ export async function createBrowserTestEnv(): Promise<BrowserTestEnv> {
     menuEventService: services.menuEventService,
     voiceService: services.voiceService,
     telemetryService: services.telemetryService,
+    sessionUsageService: services.sessionUsageService,
   };
 
   const orpc = createOrpcTestClient(orpcContext);