fix: UTs and add more scenarios

Author: fioan89

src/test/kotlin/com/coder/toolbox/util/CoderProtocolHandlerTest.kt

@@ -55,7 +55,7 @@ class CoderProtocolHandlerTest {
             // Feed returns empty or irrelevant EAPs
             coEvery { feedService.fetchEapFeed() } returns emptyList()
 
-            assertEquals("RR-241.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_eap"))
+            assertEquals("241.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_eap"))
         }
 
     @Test
@@ -68,7 +68,7 @@ class CoderProtocolHandlerTest {
                 Ide("RR", "243.1", "2024.3", IdeType.EAP)
             )
 
-            assertEquals("RR-243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_eap"))
+            assertEquals("243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_eap"))
         }
 
     @Test
@@ -84,7 +84,7 @@ class CoderProtocolHandlerTest {
             coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-243.1", "RR-242.1")
             coEvery { feedService.fetchReleaseFeed() } returns emptyList()
 
-            assertEquals("RR-243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_release"))
+            assertEquals("243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_release"))
         }
 
     @Test
@@ -97,15 +97,15 @@ class CoderProtocolHandlerTest {
                 Ide("RR", "242.1", "2024.2", IdeType.RELEASE)
             )
 
-            assertEquals("RR-242.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_release"))
+            assertEquals("242.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_release"))
         }
 
     @Test
     fun `given installed tools exist when resolving latest installed then returns max installed version`() =
         runTest(dispatcher) {
             coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns listOf("RR-240.1", "RR-241.1")
 
-            assertEquals("RR-241.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_installed"))
+            assertEquals("241.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_installed"))
         }
 
     @Test
@@ -114,7 +114,7 @@ class CoderProtocolHandlerTest {
             coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns emptyList()
             coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-243.1", "RR-242.1")
 
-            assertEquals("RR-243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_installed"))
+            assertEquals("243.1", handler.resolveIdeIdentifier("env-1", "RR", "latest_installed"))
         }
 
     @Test
@@ -127,25 +127,25 @@ class CoderProtocolHandlerTest {
         }
 
     @Test
-    fun `given specific build exists in available tools but not in installed then expect the available match to be returned`() =
+    fun `given specific build exists in installed tools but not in available then expect the installed match to be returned`() =
         runTest(dispatcher) {
             coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-241.1", "RR-242.1")
             coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns listOf("RR-251.1", "RR-252.1")
 
-            assertEquals("RR-241.1", handler.resolveIdeIdentifier("env-1", "RR", "241.1"))
+            assertEquals("251.1", handler.resolveIdeIdentifier("env-1", "RR", "251.1"))
         }
 
     @Test
-    fun `given specific build exists in installed tools but not in available then expect the installed match to be returned`() =
+    fun `given specific build exists in available tools but not in installed then expect the available match to be returned`() =
         runTest(dispatcher) {
             coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-241.1", "RR-242.1")
             coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns listOf("RR-251.1", "RR-252.1")
 
-            assertEquals("RR-251.1", handler.resolveIdeIdentifier("env-1", "RR", "251.1"))
+            assertEquals("241.1", handler.resolveIdeIdentifier("env-1", "RR", "241.1"))
         }
 
     @Test
-    fun `given specific build does not exist in installed tools nor in the  available tools then null should be returned`() =
+    fun `given specific build does not exist in installed tools nor in the available tools then null should be returned`() =
         runTest(dispatcher) {
             coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-241.1", "RR-242.1")
             coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns listOf("RR-251.1", "RR-252.1")
@@ -154,10 +154,19 @@ class CoderProtocolHandlerTest {
         }
 
     @Test
-    fun `given specific build does not exist in available tools when resolving specific build then constructs identifier`() =
+    fun `installed build takes precedence over available tools when matching a build number`() =
         runTest(dispatcher) {
-            coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf("RR-242.1")
+            coEvery { remoteToolsHelper.getAvailableRemoteTools("env-1", "RR") } returns listOf(
+                "RR-241.1.3",
+                "RR-242.1"
+            )
+            coEvery { remoteToolsHelper.getInstalledRemoteTools("env-1", "RR") } returns listOf(
+                "RR-241.1.2",
+                "RR-252.1"
+            )
 
-            assertEquals("RR-200.1", handler.resolveIdeIdentifier("env-1", "RR", "200.1"))
+            assertEquals("241.1.2", handler.resolveIdeIdentifier("env-1", "RR", "241.1"))
         }
+
+
 }