fix: Apply suggestions

Author: neznaika0

system/Session/Handlers/BaseHandler.php

@@ -95,7 +95,7 @@ abstract class BaseHandler implements SessionHandlerInterface
      * The 'save path' for the session
      * varies between.
      *
-     * @var string
+     * @var array<string, mixed>|string
      */
     protected $savePath;
 

system/Session/Session.php

@@ -152,7 +152,9 @@ protected function configure()
     {
         ini_set('session.name', $this->config->cookieName);
 
-        $sameSite = $this->cookie->getSameSite() ?? ucfirst(Cookie::SAMESITE_LAX);
+        $sameSite = $this->cookie->getSameSite() === ''
+            ? ucfirst(Cookie::SAMESITE_LAX)
+            : $this->cookie->getSameSite();
 
         $params = [
             'lifetime' => $this->config->expiration,

user_guide_src/source/libraries/sessions.rst

@@ -395,7 +395,7 @@ All session data (including flashdata and tempdata) will be destroyed permanentl
 stop()
 ------
 
-.. important:: This method was deprecated as of version v4.3.5 and was removed in v4.7.0.
+.. deprecated:: 4.3.5
 
 The session class also has the ``stop()`` method.
 

utils/phpstan-baseline/assign.propertyType.neon

@@ -1,4 +1,4 @@
-# total 30 errors
+# total 29 errors
 
 parameters:
     ignoreErrors:
@@ -12,11 +12,6 @@ parameters:
             count: 1
             path: ../../system/Controller.php
 
-        -
-            message: '#^Property CodeIgniter\\Session\\Handlers\\BaseHandler\:\:\$savePath \(string\) does not accept array\<string, array\<mixed\>\|float\|int\|string\|null\>\.$#'
-            count: 1
-            path: ../../system/Session/Handlers/RedisHandler.php
-
         -
             message: '#^Property CodeIgniter\\Commands\\Utilities\\Routes\\FilterFinderTest\:\:\$response \(CodeIgniter\\HTTP\\Response\) does not accept CodeIgniter\\HTTP\\ResponseInterface\.$#'
             count: 1

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 2739 errors
+# total 2736 errors
 
 includes:
     - argument.type.neon

utils/phpstan-baseline/offsetAccess.notFound.neon

@@ -1,22 +1,7 @@
-# total 5 errors
+# total 2 errors
 
 parameters:
     ignoreErrors:
-        -
-            message: '#^Offset ''host'' does not exist on non\-falsy\-string\.$#'
-            count: 1
-            path: ../../system/Session/Handlers/RedisHandler.php
-
-        -
-            message: '#^Offset ''port'' does not exist on non\-falsy\-string\.$#'
-            count: 1
-            path: ../../system/Session/Handlers/RedisHandler.php
-
-        -
-            message: '#^Offset ''timeout'' does not exist on non\-falsy\-string\.$#'
-            count: 1
-            path: ../../system/Session/Handlers/RedisHandler.php
-
         -
             message: '#^Offset ''_ci_old_input'' does not exist on array\{\}\.$#'
             count: 2

utils/phpstan-baseline/property.phpDocType.neon

@@ -1,4 +1,4 @@
-# total 43 errors
+# total 44 errors
 
 parameters:
     ignoreErrors:
@@ -167,6 +167,11 @@ parameters:
             count: 1
             path: ../../system/Images/Handlers/ImageMagickHandler.php
 
+        -
+            message: '#^PHPDoc type string of property CodeIgniter\\Session\\Handlers\\FileHandler\:\:\$savePath is not the same as PHPDoc type array\<string, mixed\>\|string of overridden property CodeIgniter\\Session\\Handlers\\BaseHandler\:\:\$savePath\.$#'
+            count: 1
+            path: ../../system/Session/Handlers/FileHandler.php
+
         -
             message: '#^PHPDoc type CodeIgniter\\Test\\Mock\\MockConnection of property CodeIgniter\\Database\\Builder\\InsertTest\:\:\$db is not the same as PHPDoc type CodeIgniter\\Database\\BaseConnection of overridden property CodeIgniter\\Test\\CIUnitTestCase\:\:\$db\.$#'
             count: 1