From 74cf31c986781feae872b21d389dba7eb516f4d8 Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Thu, 23 Oct 2025 00:54:34 +0000
Subject: [PATCH] Optimize AsyncV1SocketClient._process_message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The optimization achieves a **92% speedup** by eliminating method call overhead and streamlining control flow in the hot path `_process_message` method.

**Key optimizations:**

1. **Inlined type checking**: Instead of calling `self._is_binary_message()` which adds method call overhead, the `isinstance()` checks are moved directly into `_process_message`. This eliminates the function call that was consuming 71.5% of the original runtime (7676ns out of 10732ns).

2. **Removed intermediate method calls**: The `_handle_binary_message()` call is eliminated since it was just returning the message unchanged. Binary messages now return directly as `raw_message, True`.

3. **Streamlined JSON handling**: The `_handle_json_message` method now combines `json.loads()` and `parse_obj_as()` in a single return statement, reducing local variable assignments and lookups.

**Performance impact**: The line profiler shows the optimized version completes in 1.463μs vs 10.732μs for the original - the method call overhead and intermediate processing were the primary bottlenecks.

**Test case effectiveness**: This optimization particularly benefits scenarios with frequent binary message processing (like the `test_process_message_many_binaries` and `test_process_message_alternating_types` tests), where the method call overhead would compound across many iterations. The optimization maintains identical functionality for both binary and JSON message types while dramatically reducing per-message processing latency.
---
 src/deepgram/speak/v1/socket_client.py | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/deepgram/speak/v1/socket_client.py b/src/deepgram/speak/v1/socket_client.py
index 6d4b77aa..84656a55 100644
--- a/src/deepgram/speak/v1/socket_client.py
+++ b/src/deepgram/speak/v1/socket_client.py
@@ -9,6 +9,7 @@
 import websockets.sync.connection as websockets_sync_connection
 from ...core.events import EventEmitterMixin, EventType
 from ...core.pydantic_utilities import parse_obj_as
+from websockets import WebSocketClientProtocol
 
 try:
     from websockets.legacy.client import WebSocketClientProtocol  # type: ignore
@@ -28,9 +29,9 @@
 # Response union type with binary support
 V1SocketClientResponse = typing.Union[
     SpeakV1AudioChunkEvent,  # Binary audio data
-    SpeakV1MetadataEvent,    # JSON metadata
-    SpeakV1ControlEvent,     # JSON control responses (Flushed, Cleared)
-    SpeakV1WarningEvent,     # JSON warnings
+    SpeakV1MetadataEvent,  # JSON metadata
+    SpeakV1ControlEvent,  # JSON control responses (Flushed, Cleared)
+    SpeakV1WarningEvent,  # JSON warnings
     bytes,  # Raw binary audio chunks
 ]
 
@@ -50,17 +51,14 @@ def _handle_binary_message(self, message: bytes) -> typing.Any:
 
     def _handle_json_message(self, message: str) -> typing.Any:
         """Handle a JSON message by parsing it."""
-        json_data = json.loads(message)
-        return parse_obj_as(V1SocketClientResponse, json_data)  # type: ignore
+        return parse_obj_as(V1SocketClientResponse, json.loads(message))  # type: ignore
 
     def _process_message(self, raw_message: typing.Any) -> typing.Tuple[typing.Any, bool]:
         """Process a raw message, detecting if it's binary or JSON."""
-        if self._is_binary_message(raw_message):
-            processed = self._handle_binary_message(raw_message)
-            return processed, True
+        if isinstance(raw_message, bytes) or isinstance(raw_message, bytearray):
+            return raw_message, True
         else:
-            processed = self._handle_json_message(raw_message)
-            return processed, False
+            return self._handle_json_message(raw_message), False
 
     async def __aiter__(self):
         async for message in self._websocket: