From 0fcfacdd5ebcf20b7ce426d3535eacc997d419fe Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Tue, 3 Feb 2026 06:50:01 +0000
Subject: [PATCH] Optimize ImportResolver._is_external_package
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The optimization achieves a **41% runtime improvement** (539μs → 379μs) by consolidating four sequential `startswith()` checks into a single tuple-based check.

**Key optimization:** Python's `str.startswith()` method accepts a tuple of prefixes and performs the check in optimized C code, scanning the string once rather than four times. The original code made four separate method calls:
```python
if module_path.startswith("."):
    return False
if module_path.startswith("/"):
    return False
if module_path.startswith("@/"):
    return False
if module_path.startswith("~/"):
    return False
```

The optimized version combines these into one check:
```python
if module_path.startswith((".", "/", "@/", "~/")):
    return False
```

**Why this is faster:**
1. **Single method call overhead:** Reduces four method invocations to one
2. **Single string scan:** The internal C implementation scans the string once to test all prefixes, rather than potentially scanning up to four times
3. **Short-circuit evaluation:** Once any prefix matches, the check completes immediately

**Line profiler evidence:** The original code spent 1,745,286ns across multiple checks (30.5% + 23.7% + 16.4% + 12.4% = 83% of total time). The optimized version completes the same logic in 709,412ns (64.6% of total time), representing a ~60% reduction in the critical path.

**Test case analysis:** The optimization excels across all scenarios:
- **Alias patterns** (`@/` and `~/`): 28-73% faster since these previously required checking three prefixes before matching
- **Bare imports** (external packages): 40-83% faster as they now fail all four prefix checks in a single operation
- **Large-scale batches**: 42-73% faster for mixed workloads and scoped packages

The optimization maintains identical behavior and correctness while delivering consistent performance gains across all import types commonly found in JavaScript/TypeScript projects.
---
 codeflash/languages/javascript/import_resolver.py | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/codeflash/languages/javascript/import_resolver.py b/codeflash/languages/javascript/import_resolver.py
index 4e237b8d6..740768067 100644
--- a/codeflash/languages/javascript/import_resolver.py
+++ b/codeflash/languages/javascript/import_resolver.py
@@ -301,20 +301,11 @@ def _is_external_package(self, module_path: str) -> bool:
 
         """
         # Relative imports are not external
-        if module_path.startswith("."):
-            return False
-
         # Absolute imports (starting with /) are project-internal
-        if module_path.startswith("/"):
-            return False
-
         # @/ is a common path alias in Next.js/TypeScript projects mapping to project root
         # These are internal imports, not external npm packages
-        if module_path.startswith("@/"):
-            return False
-
         # ~/ is another common path alias pattern
-        if module_path.startswith("~/"):
+        if module_path.startswith((".", "/", "@/", "~/")):
             return False
 
         # Bare imports without ./ or ../ are external packages