From 1fa6fbaca910eaf6fb6d3a2a7b5537009e87123d Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Fri, 30 Jan 2026 08:18:56 +0000
Subject: [PATCH] Optimize list_pop_range
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The optimization achieves a **9% runtime improvement** (365μs → 334μs) through two key changes:

## Primary Optimization: Eliminate Redundant Dictionary Operations

The original code creates a base dictionary and then conditionally adds the `CTX_KEY`:
```python
op_dict = {OP_KEY: aerospike.OP_LIST_POP_RANGE, ...}  # Create dict
if ctx:
    op_dict[CTX_KEY] = ctx  # Mutate dict
return op_dict
```

The optimized version builds the complete dictionary in one expression based on the branch:
```python
if ctx:
    return {OP_KEY: _OP_LIST_POP_RANGE, ..., CTX_KEY: ctx}
return {OP_KEY: _OP_LIST_POP_RANGE, ...}
```

This eliminates the dictionary mutation overhead (the `op_dict[CTX_KEY] = ctx` assignment), which line profiler shows took ~74μs (4% of original runtime). Building the dictionary once rather than creating then modifying it is faster in Python.

## Secondary Optimization: Cache Module Attribute Lookup

The constant `_OP_LIST_POP_RANGE = aerospike.OP_LIST_POP_RANGE` is cached at module load time. This avoids the repeated `aerospike.OP_LIST_POP_RANGE` attribute lookup on every function call. While module attribute lookups are relatively fast in Python, eliminating them from a hot path still provides measurable gains.

## Performance Characteristics

The annotated tests show consistent improvements across all scenarios:
- **Simple cases** (no ctx): 15-35% faster (e.g., `test_basic_pop_range_single_item`: 19% faster)
- **With context**: 15-44% faster (e.g., `test_includes_ctx_when_nonempty_list_provided`: 43.9% faster)
- **Large-scale operations**: 7-8% faster even when creating 100-500 operations sequentially

The optimization is particularly effective when `ctx` is provided (the conditional branch with higher overhead in the original), making this beneficial for workloads that frequently use CDT context operations with Aerospike lists.
---
 aerospike_helpers/operations/list_operations.py | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
 mode change 100755 => 100644 aerospike_helpers/operations/list_operations.py

diff --git a/aerospike_helpers/operations/list_operations.py b/aerospike_helpers/operations/list_operations.py
old mode 100755
new mode 100644
index 238929bd4a..63af9ba0df
--- a/aerospike_helpers/operations/list_operations.py
+++ b/aerospike_helpers/operations/list_operations.py
@@ -31,6 +31,8 @@
 import aerospike
 from typing import Optional
 
+_OP_LIST_POP_RANGE = aerospike.OP_LIST_POP_RANGE
+
 
 OP_KEY = "op"
 BIN_KEY = "bin"
@@ -268,12 +270,11 @@ def list_pop_range(bin_name: str, index, count, ctx: Optional[list] = None):
         A dictionary usable in :meth:`~aerospike.Client.operate` and :meth:`~aerospike.Client.operate_ordered`. The
         format of the dictionary should be considered an internal detail, and subject to change.
     """
-    op_dict = {OP_KEY: aerospike.OP_LIST_POP_RANGE, BIN_KEY: bin_name, INDEX_KEY: index, VALUE_KEY: count}
 
     if ctx:
-        op_dict[CTX_KEY] = ctx
-
-    return op_dict
+        return {OP_KEY: _OP_LIST_POP_RANGE, BIN_KEY: bin_name, INDEX_KEY: index, VALUE_KEY: count, CTX_KEY: ctx}
+    
+    return {OP_KEY: _OP_LIST_POP_RANGE, BIN_KEY: bin_name, INDEX_KEY: index, VALUE_KEY: count}
 
 
 def list_remove(bin_name: str, index, ctx: Optional[list] = None):