Skip to content

Commit 24ba912

Browse files
DavertMikclaude
andcommitted
ci: drop self-symlink workaround now that companion betas read globalThis
@codeceptjs/configure@4.0.0-beta.4 and @codeceptjs/expect-helper@4.0.0-beta.5 no longer do top-level `import 'codeceptjs'` — they read from the globalThis.codeceptjs registry the runner sets up in lib/host.js. The self-symlink that fed them a resolvable codeceptjs package in CI is no longer needed. - Bump @codeceptjs/configure to ^4.0.0-beta.4 - Bump @codeceptjs/expect-helper to ^4.0.0-beta.5 - Remove the `ln -sfn .. node_modules/codeceptjs` step from dtslint, playwright, plugin, puppeteer, webdriver, and test workflows - Delete scripts/upstream-patches/ — the patches it documented are now released in the companion packages Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 8742f93 commit 24ba912

10 files changed

Lines changed: 2 additions & 106 deletions

File tree

.github/workflows/dtslint.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,5 @@ jobs:
2828
env:
2929
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
3030
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
31-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
32-
- run: ln -sfn .. node_modules/codeceptjs
3331
- run: npm run def
3432
- run: npm run dtslint

.github/workflows/playwright.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
npm i --force
4141
env:
4242
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
43-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
44-
- run: ln -sfn .. node_modules/codeceptjs
4543
- name: Allow Release info Change
4644
run: |
4745
sudo apt-get update --allow-releaseinfo-change

.github/workflows/plugin.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
npm i --force
4141
env:
4242
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
43-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
44-
- run: ln -sfn .. node_modules/codeceptjs
4543
- name: Allow Release info Change
4644
run: |
4745
sudo apt-get update --allow-releaseinfo-change

.github/workflows/puppeteer.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ jobs:
4040
npm i --force && npm i puppeteer --force
4141
env:
4242
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
43-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
44-
- run: ln -sfn .. node_modules/codeceptjs
4543
- name: Start mock server
4644
run: nohup npm run mock-server:start &
4745
- name: Wait for mock server

.github/workflows/test.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ jobs:
3232
env:
3333
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
3434
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
35-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
36-
- run: ln -sfn .. node_modules/codeceptjs
3735
- name: Start mock server
3836
run: nohup npm run mock-server:start &
3937
- name: Wait for mock server
@@ -74,8 +72,6 @@ jobs:
7472
env:
7573
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
7674
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
77-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
78-
- run: ln -sfn .. node_modules/codeceptjs
7975
- name: Start mock server
8076
run: nohup npm run mock-server:start &
8177
- name: Wait for mock server

.github/workflows/webdriver.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ jobs:
4141
env:
4242
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
4343
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
44-
# Self-link so deps that `import 'codeceptjs'` (configure, expect-helper) resolve.
45-
- run: ln -sfn .. node_modules/codeceptjs
4644
- name: Start mock server
4745
run: nohup npm run mock-server:start &
4846
- name: Wait for mock server

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
"publish-beta": "./runok.cjs publish:next-beta-version"
8888
},
8989
"dependencies": {
90-
"@codeceptjs/configure": "^4.0.0-beta.2",
90+
"@codeceptjs/configure": "^4.0.0-beta.4",
9191
"@codeceptjs/helper": "2.0.4",
9292
"@cucumber/cucumber-expressions": "18",
9393
"@cucumber/gherkin": "38.0.0",
@@ -138,7 +138,7 @@
138138
},
139139
"devDependencies": {
140140
"@apollo/server": "^5",
141-
"@codeceptjs/expect-helper": "^4.0.0-beta.3",
141+
"@codeceptjs/expect-helper": "^4.0.0-beta.5",
142142
"@codeceptjs/mock-request": "0.3.1",
143143
"@eslint/eslintrc": "3.3.3",
144144
"@eslint/js": "9.39.2",

scripts/upstream-patches/README.md

Lines changed: 0 additions & 27 deletions
This file was deleted.

scripts/upstream-patches/configure-codeceptjs.js

Lines changed: 0 additions & 39 deletions
This file was deleted.

scripts/upstream-patches/expect-helper-index.js.diff

Lines changed: 0 additions & 24 deletions
This file was deleted.

0 commit comments

Comments
 (0)