Skip to content

Commit 2fcf899

Browse files
committed
[Added] validation of domain
[Fixed] overHttp always true
1 parent e6f42ba commit 2fcf899

3 files changed

Lines changed: 62 additions & 21 deletions

File tree

README.md

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,36 @@ port on which request will send. Default 443
2626
## Example Usage
2727
```yaml
2828
- name: Docker Pull Auto
29-
uses: codebysandip/docker-pull-auto@v1.2
29+
uses: codebysandip/docker-pull-auto@v1.3
3030
with:
3131
docker-image: sandipj/react-ssr-doc
3232
docker-tag: prod-1.0
3333
domain: myawesomeapp.com
3434
hook-secret: ${{ secrets.HOOK_SECRET}}
3535
```
3636
HOOK_SECRET of docker pull auto action and [docker pull auto](https://codebysandip.github.io/docker-pull-auto) must be same
37+
38+
## Use http request
39+
```yaml
40+
- name: Docker Pull Auto
41+
uses: codebysandip/docker-pull-auto@v1.3
42+
with:
43+
docker-image: sandipj/react-ssr-doc
44+
docker-tag: prod-1.0
45+
domain: myawesomeapp.com
46+
hook-secret: ${{ secrets.HOOK_SECRET}}
47+
over-http: true
48+
```
49+
50+
## Send Request to specific port over http
51+
```yaml
52+
- name: Docker Pull Auto
53+
uses: codebysandip/docker-pull-auto@v1.3
54+
with:
55+
docker-image: sandipj/react-ssr-doc
56+
docker-tag: prod-1.0
57+
domain: myawesomeapp.com
58+
hook-secret: ${{ secrets.HOOK_SECRET}}
59+
over-http: true
60+
port: 3000
61+
```

dist/index.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2839,9 +2839,18 @@ const obj = {
28392839
dockerTag: core.getInput("docker-tag"),
28402840
domain: core.getInput("domain"),
28412841
hookSecret: core.getInput("hook-secret"),
2842-
overHttp: core.getInput("over-http"),
2843-
port: core.getInput("port")
2842+
overHttp: JSON.parse(core.getInput("over-http")),
2843+
port: JSON.parse(core.getInput("port"))
28442844
};
2845+
console.log("typeof overHttp", typeof core.getInput("over-http"));
2846+
console.log("typeof port", typeof core.getInput("port"));
2847+
2848+
try {
2849+
new URL(`http://${obj.domain}`);
2850+
} catch {
2851+
console.error(`Invalid domain ${obj.domain}. Example value example.com or sub.example.com`);
2852+
process.exit(1);
2853+
}
28452854
// for local testing
28462855
// const obj = {};
28472856
// const args = process.argv.slice(2);
@@ -2902,8 +2911,6 @@ const options = {
29022911
},
29032912
};
29042913

2905-
console.log("request options!!", options);
2906-
29072914
const req = adapter.request(options, function (res) {
29082915
console.log("STATUS: " + res.statusCode);
29092916
res.setEncoding("utf8");

index.js

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,29 @@
1-
// const core = require('@actions/core');
2-
3-
// const obj = {
4-
// dockerImage: core.getInput("docker-image"),
5-
// dockerTag: core.getInput("docker-tag"),
6-
// domain: core.getInput("domain"),
7-
// hookSecret: core.getInput("hook-secret"),
8-
// overHttp: core.getInput("over-http"),
9-
// port: core.getInput("port")
10-
// };
1+
const core = require('@actions/core');
2+
3+
const obj = {
4+
dockerImage: core.getInput("docker-image"),
5+
dockerTag: core.getInput("docker-tag"),
6+
domain: core.getInput("domain"),
7+
hookSecret: core.getInput("hook-secret"),
8+
overHttp: JSON.parse(core.getInput("over-http")),
9+
port: JSON.parse(core.getInput("port"))
10+
};
11+
console.log("typeof overHttp", typeof core.getInput("over-http"));
12+
console.log("typeof port", typeof core.getInput("port"));
13+
14+
try {
15+
new URL(`http://${obj.domain}`);
16+
} catch {
17+
console.error(`Invalid domain ${obj.domain}. Example value example.com or sub.example.com`);
18+
process.exit(1);
19+
}
1120
// for local testing
12-
const obj = {};
13-
const args = process.argv.slice(2);
14-
args.forEach((arg) => {
15-
const splittedVal = arg.split("=");
16-
obj[splittedVal[0]] = splittedVal[1] || true;
17-
});
21+
// const obj = {};
22+
// const args = process.argv.slice(2);
23+
// args.forEach((arg) => {
24+
// const splittedVal = arg.split("=");
25+
// obj[splittedVal[0]] = splittedVal[1] || true;
26+
// });
1827

1928
if (!obj.dockerImage) {
2029
console.error("docker image not passed as parameter. Example dockerImage=sandipj/react-ssr-doc");

0 commit comments

Comments
 (0)