feat: cli implements new definition fields

Author: raphael-goetz

crates/cli/src/analyser/data_type.rs

@@ -26,6 +26,25 @@ impl Analyser {
             ));
         }
 
+        if dt.alias.is_empty() {
+            self.reporter.add(Diagnose::new(
+                dt.identifier.clone(),
+                adt.original_definition.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "alias".into(),
+                },
+            ));
+        }
+
+        if dt.display_message.is_empty() {
+            self.reporter.add(Diagnose::new(
+                dt.identifier.clone(),
+                adt.original_definition.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "displayMessage".into(),
+                },
+            ));
+        }
         let mut detected: Vec<String> = vec![];
         for optional_rule in &dt.rules {
             if let Some(config) = &optional_rule.config {

crates/cli/src/analyser/flow_type.rs

@@ -8,6 +8,35 @@ impl Analyser {
         let name = flow.identifier.clone();
         let original = aft.original_definition.clone();
 
+        if flow.display_icon.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::NullField {
+                    field_name: "displayIcon".into(),
+                },
+            ))
+        }
+        if flow.alias.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "alias".into(),
+                },
+            ));
+        }
+
+        if flow.display_message.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "displayMessage".into(),
+                },
+            ));
+        }
+
         if flow.name.is_empty() {
             self.reporter.add(Diagnose::new(
                 name.clone(),

crates/cli/src/analyser/function.rs

@@ -10,6 +10,36 @@ impl Analyser {
         let function = &af.function;
         let original = af.original_definition.clone();
 
+        if function.display_icon.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::NullField {
+                    field_name: "displayIcon".into(),
+                },
+            ))
+        }
+
+        if function.alias.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "alias".into(),
+                },
+            ));
+        }
+
+        if function.display_message.is_empty() {
+            self.reporter.add(Diagnose::new(
+                name.clone(),
+                original.clone(),
+                DiagnosticKind::MissingTranslation {
+                    translation_field: "displayMessage".into(),
+                },
+            ));
+        }
+
         if function.name.is_empty() {
             self.reporter.add(Diagnose::new(
                 name.clone(),

crates/cli/src/diagnostics/diagnose.rs

@@ -111,7 +111,14 @@ impl Diagnose {
                 ),
                 &path,
             ),
-        }
+            MissingTranslation { translation_field } => error(
+                format!(
+                    "`{}` has an required empty field (`{}`) of translations!",
+                    self.definition_name, translation_field
+                ),
+                &path,
+            ),
+         }
     }
 
     pub fn severity(&self) -> Severity {

crates/cli/src/diagnostics/kinds.rs

@@ -15,6 +15,7 @@ pub enum DiagnosticKind {
     UnusedGenericKey { key: String },
     UndefinedGenericKey { key: String },
     UndefinedTranslation { translation_field: String },
+    MissingTranslation { translation_field: String },
 }
 
 impl DiagnosticKind {
@@ -32,7 +33,8 @@ impl DiagnosticKind {
             | NullField { .. }
             | ForbiddenVariant
             | UnusedGenericKey { .. }
-            | UndefinedGenericKey { .. } => Severity::Error,
+            | UndefinedGenericKey { .. }
+            | MissingTranslation { .. } => Severity::Error,
             UndefinedTranslation { .. } => Severity::Warning,
         }
     }