From f13abbbb4466572afdb3932760ae64e12354a3c3 Mon Sep 17 00:00:00 2001 From: Szymon Chmal Date: Wed, 15 Jan 2025 19:41:22 +0100 Subject: [PATCH 1/2] Fix copy functionality in Firefox (#32077) ## Summary This pull request addresses an issue where the copy functionality was not working in Firefox. The root cause was the absence of the 'clipboardWrite' permission in the manifest. To ensure consistency across all supported browsers, the 'clipboardWrite' permission has been added to the manifests for Chrome, Edge, and Firefox extensions. Closes #31422 ## How did you test this change? I ran the modified extension in all browsers (MacOS) and verified that the copy functionality works in each. https://github.com/user-attachments/assets/a41ff14b-3d65-409c-ac7f-1ccd72fa944a --- packages/react-devtools-extensions/chrome/manifest.json | 3 ++- packages/react-devtools-extensions/edge/manifest.json | 3 ++- packages/react-devtools-extensions/firefox/manifest.json | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/react-devtools-extensions/chrome/manifest.json b/packages/react-devtools-extensions/chrome/manifest.json index 7f29a597029..8eb00dbff83 100644 --- a/packages/react-devtools-extensions/chrome/manifest.json +++ b/packages/react-devtools-extensions/chrome/manifest.json @@ -43,7 +43,8 @@ "permissions": [ "scripting", "storage", - "tabs" + "tabs", + "clipboardWrite" ], "host_permissions": [ "" diff --git a/packages/react-devtools-extensions/edge/manifest.json b/packages/react-devtools-extensions/edge/manifest.json index dcf1448b087..bc636f2568b 100644 --- a/packages/react-devtools-extensions/edge/manifest.json +++ b/packages/react-devtools-extensions/edge/manifest.json @@ -43,7 +43,8 @@ "permissions": [ "scripting", "storage", - "tabs" + "tabs", + "clipboardWrite" ], "host_permissions": [ "" diff --git a/packages/react-devtools-extensions/firefox/manifest.json b/packages/react-devtools-extensions/firefox/manifest.json index 98c8079546e..e8dd2afad9c 100644 --- a/packages/react-devtools-extensions/firefox/manifest.json +++ b/packages/react-devtools-extensions/firefox/manifest.json @@ -50,7 +50,8 @@ "permissions": [ "scripting", "storage", - "tabs" + "tabs", + "clipboardWrite" ], "host_permissions": [ "" From 87276ef1efb340467563c107f24248653d7f7f00 Mon Sep 17 00:00:00 2001 From: Ricky Date: Wed, 15 Jan 2025 16:41:31 -0600 Subject: [PATCH 2/2] [actions] split out compiler notify (#32079) --- .github/workflows/shared_discord_notify.yml | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/.github/workflows/shared_discord_notify.yml b/.github/workflows/shared_discord_notify.yml index 86fd28af3ba..da80c32ee21 100644 --- a/.github/workflows/shared_discord_notify.yml +++ b/.github/workflows/shared_discord_notify.yml @@ -5,8 +5,8 @@ on: types: [labeled] jobs: - notify: - if: ${{ github.event.label.name == 'React Core Team' }} + notify_core: + if: ${{ !contains(github.event.pull_request.title, '[compiler]') && github.event.label.name == 'React Core Team' }} runs-on: ubuntu-latest steps: - name: Discord Webhook Action @@ -19,3 +19,17 @@ jobs: embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}' embed-description: ${{ github.event.pull_request.body }} embed-url: ${{ github.event.pull_request.html_url }} + notify_compiler: + if: ${{ contains(github.event.pull_request.title, '[compiler]') && github.event.label.name == 'React Core Team' }} + runs-on: ubuntu-latest + steps: + - name: Discord Webhook Action + uses: tsickert/discord-webhook@v6.0.0 + with: + webhook-url: ${{ secrets.COMPILER_DISCORD_WEBHOOK_URL }} + embed-author-name: ${{ github.event.pull_request.user.login }} + embed-author-url: ${{ github.event.pull_request.user.html_url }} + embed-author-icon-url: ${{ github.event.pull_request.user.avatar_url }} + embed-title: '#${{ github.event.number }} (+${{github.event.pull_request.additions}} -${{github.event.pull_request.deletions}}): ${{ github.event.pull_request.title }}' + embed-description: ${{ github.event.pull_request.body }} + embed-url: ${{ github.event.pull_request.html_url }}