Commit d74f061
authored
[Fiber] Clean up ViewTransition when it fails to start (facebook#34676)
The View Transition docs were unclear about this but apparently the
`finished` promise never settles if the animation never started. So if
there's an error that rejects the `ready` promise, we'll never run the
clean up which can cause it to stall.
Fixes facebook#34662.
However, ultimately that is caused by Chrome stalling our default
`onDefaultTransitionIndicator` but it should be unblocked after 10
seconds, not a minute.1 parent f7254ef commit d74f061
File tree
1 file changed
+16
-0
lines changed- packages/react-dom-bindings/src/client
1 file changed
+16
-0
lines changedLines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2279 | 2279 | | |
2280 | 2280 | | |
2281 | 2281 | | |
| 2282 | + | |
| 2283 | + | |
| 2284 | + | |
| 2285 | + | |
| 2286 | + | |
2282 | 2287 | | |
2283 | 2288 | | |
2284 | 2289 | | |
| |||
2293 | 2298 | | |
2294 | 2299 | | |
2295 | 2300 | | |
| 2301 | + | |
| 2302 | + | |
| 2303 | + | |
2296 | 2304 | | |
2297 | 2305 | | |
2298 | 2306 | | |
| |||
2699 | 2707 | | |
2700 | 2708 | | |
2701 | 2709 | | |
| 2710 | + | |
| 2711 | + | |
| 2712 | + | |
| 2713 | + | |
| 2714 | + | |
2702 | 2715 | | |
2703 | 2716 | | |
2704 | 2717 | | |
| |||
2713 | 2726 | | |
2714 | 2727 | | |
2715 | 2728 | | |
| 2729 | + | |
| 2730 | + | |
| 2731 | + | |
2716 | 2732 | | |
2717 | 2733 | | |
2718 | 2734 | | |
| |||
0 commit comments