Commit a49952b
authored
Properly clean up gesture Animations (facebook#35559)
Follow up to facebook#35337.
During a gesture, we always cancel the original animation and create a
new one that we control. That's the one we need to add to the set that
needs to be cancelled. Otherwise future gestures hang.
An unfortunate consequence is that any custom ones that you start e.g.
with facebook#35556 or through other means aren't automatically cleaned up (in
fact there's not even a clean up callback yet). This can lead these to
freeze the whole UI afterwards. It would be really good to get this
fixed in browsers instead so we can revert facebook#35337.1 parent 4bcf67e commit a49952b
1 file changed
Lines changed: 10 additions & 3 deletions
Lines changed: 10 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2372 | 2372 | | |
2373 | 2373 | | |
2374 | 2374 | | |
| 2375 | + | |
2375 | 2376 | | |
2376 | 2377 | | |
2377 | 2378 | | |
| |||
2464 | 2465 | | |
2465 | 2466 | | |
2466 | 2467 | | |
2467 | | - | |
| 2468 | + | |
2468 | 2469 | | |
2469 | 2470 | | |
2470 | 2471 | | |
| |||
2482 | 2483 | | |
2483 | 2484 | | |
2484 | 2485 | | |
| 2486 | + | |
2485 | 2487 | | |
2486 | 2488 | | |
2487 | 2489 | | |
| |||
2554 | 2556 | | |
2555 | 2557 | | |
2556 | 2558 | | |
2557 | | - | |
2558 | | - | |
| 2559 | + | |
| 2560 | + | |
| 2561 | + | |
| 2562 | + | |
2559 | 2563 | | |
2560 | 2564 | | |
2561 | 2565 | | |
| |||
2648 | 2652 | | |
2649 | 2653 | | |
2650 | 2654 | | |
| 2655 | + | |
2651 | 2656 | | |
2652 | 2657 | | |
2653 | 2658 | | |
| |||
2675 | 2680 | | |
2676 | 2681 | | |
2677 | 2682 | | |
| 2683 | + | |
2678 | 2684 | | |
2679 | 2685 | | |
2680 | 2686 | | |
| |||
2696 | 2702 | | |
2697 | 2703 | | |
2698 | 2704 | | |
| 2705 | + | |
2699 | 2706 | | |
2700 | 2707 | | |
2701 | 2708 | | |
| |||
0 commit comments