From b21adc154c26a905b32d6514274201f0dd5f2b4d Mon Sep 17 00:00:00 2001 From: Melvin Stans Date: Tue, 18 Nov 2025 10:18:26 +0100 Subject: [PATCH 1/5] Fix helm chart lint issues (#4282) --- .github/workflows/ci.yml | 58 ++++++++++++++++--- .../workflows/trigger-helm-chart-upload.yml | 3 - .../baserow/templates/backend-configmap.yaml | 4 +- 3 files changed, 52 insertions(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 02c54a197d..2227f4d991 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -188,6 +188,7 @@ jobs: dockerfiles: ${{ steps.filter.outputs.dockerfiles }} mjml: ${{ steps.filter.outputs.mjml }} zapier: ${{ steps.filter.outputs.zapier }} + helm: ${{ steps.filter.outputs.helm }} steps: - name: Checkout code uses: actions/checkout@v4 @@ -216,7 +217,10 @@ jobs: zapier: - 'integrations/zapier/**' - '.github/workflows/ci.yml' - + helm: + - 'deploy/helm/**' + - '.github/workflows/ci.yml' + - '.github/workflows/trigger-helm-chart-upload.yml' backend-lint: name: Backend Lint runs-on: ubuntu-latest @@ -326,6 +330,44 @@ jobs: path: reports/hadolint.json retention-days: 7 + helm-chart-lint: + name: Helm Chart Lint + runs-on: ubuntu-latest + needs: + - detect-changes + permissions: + contents: read + steps: + - name: Exit early if helm not changed and not develop/master + run: | + if [[ "${{ needs.detect-changes.outputs.helm }}" != "true" && \ + "${{ github.ref_name }}" != "develop" && \ + "${{ github.ref_name }}" != "master" ]]; then + echo "No backend changes detected — skipping backend lint." + exit 0 + fi + + - name: Checkout code + uses: actions/checkout@v4 + + - name: Set up Helm + uses: azure/setup-helm@v4 + + - name: Lint Helm Chart + run: | + cd deploy/helm + rm -f baserow/Chart.lock + + # Add Helm repositories + helm repo add bitnami https://charts.bitnami.com/bitnami + helm repo add caddy https://caddyserver.github.io/ingress + + # Build dependencies + helm dependency build baserow + + # Lint the chart with strict mode + helm lint baserow --strict + # ========================================================================== # TEST STAGE - Run backend and frontend tests # ========================================================================== @@ -552,7 +594,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version: "18" - name: Run Zapier tests run: | @@ -585,7 +627,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version: "18" - name: Compile MJML templates run: | @@ -667,9 +709,9 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '18' - cache: 'yarn' - cache-dependency-path: 'e2e-tests/yarn.lock' + node-version: "18" + cache: "yarn" + cache-dependency-path: "e2e-tests/yarn.lock" - name: Log in to GitHub Container Registry uses: docker/login-action@v3 @@ -790,7 +832,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v4 with: - node-version: '18' + node-version: "18" - name: Download all E2E test results uses: actions/download-artifact@v4 @@ -832,7 +874,7 @@ jobs: - name: Set up Python uses: actions/setup-python@v5 with: - python-version: '3.11' + python-version: "3.11" - name: Install coverage tool run: pip install coverage diff --git a/.github/workflows/trigger-helm-chart-upload.yml b/.github/workflows/trigger-helm-chart-upload.yml index 81d957dded..1c0a3d9ca7 100644 --- a/.github/workflows/trigger-helm-chart-upload.yml +++ b/.github/workflows/trigger-helm-chart-upload.yml @@ -28,9 +28,6 @@ jobs: # Build dependencies helm dependency build baserow - # Lint the chart with strict mode - helm lint baserow --strict - # Package the chart helm package baserow diff --git a/deploy/helm/baserow/templates/backend-configmap.yaml b/deploy/helm/baserow/templates/backend-configmap.yaml index 473d31ca92..f2ef24c1c7 100644 --- a/deploy/helm/baserow/templates/backend-configmap.yaml +++ b/deploy/helm/baserow/templates/backend-configmap.yaml @@ -19,8 +19,8 @@ data: AWS_S3_CUSTOM_DOMAIN: {{ .Values.global.baserow.objectsDomain }}/{{ (index .Values.minio.provisioning.buckets 0).name }} AWS_S3_REGION_NAME: "us-east-1" {{- end }} -{{- if .Values.global.baserow.assistantLLMModel -}} - BASEROW_ENTERPRISE_ASSISTANT_LLM_MODEL: "{{ .Values.baserow.assistantLLMModel }}" +{{- if .Values.global.baserow.assistantLLMModel }} + BASEROW_ENTERPRISE_ASSISTANT_LLM_MODEL: "{{ .Values.global.baserow.assistantLLMModel }}" {{- end }} {{- if (index .Values "baserow-embeddings").enabled }} BASEROW_EMBEDDINGS_API_URL: http://{{ include "baserow.fullname" (index .Subcharts "baserow-embeddings") }} From d237b07c4b98a18a8117e1b38f0d380495222226 Mon Sep 17 00:00:00 2001 From: Davide Silvestri <75379892+silvestrid@users.noreply.github.com> Date: Tue, 18 Nov 2025 10:30:16 +0100 Subject: [PATCH 2/5] Don't show Kuma if the model is not set (#4281) --- ...e_assistant_panel_if_the_llm_model_env_variable_.json | 9 +++++++++ .../components/assistant/AssistantSidebarItem.vue | 6 +++++- .../web-frontend/modules/baserow_enterprise/module.js | 5 +++++ 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 changelog/entries/unreleased/bug/4280_dont_show_the_assistant_panel_if_the_llm_model_env_variable_.json diff --git a/changelog/entries/unreleased/bug/4280_dont_show_the_assistant_panel_if_the_llm_model_env_variable_.json b/changelog/entries/unreleased/bug/4280_dont_show_the_assistant_panel_if_the_llm_model_env_variable_.json new file mode 100644 index 0000000000..34ecedc56c --- /dev/null +++ b/changelog/entries/unreleased/bug/4280_dont_show_the_assistant_panel_if_the_llm_model_env_variable_.json @@ -0,0 +1,9 @@ +{ + "type": "bug", + "message": "Don't show the Assistant panel if the LLM_MODEL env variable is not configured", + "issue_origin": "github", + "issue_number": 4280, + "domain": "core", + "bullet_points": [], + "created_at": "2025-11-18" +} diff --git a/enterprise/web-frontend/modules/baserow_enterprise/components/assistant/AssistantSidebarItem.vue b/enterprise/web-frontend/modules/baserow_enterprise/components/assistant/AssistantSidebarItem.vue index eacef2afa0..7d7ba1e325 100644 --- a/enterprise/web-frontend/modules/baserow_enterprise/components/assistant/AssistantSidebarItem.vue +++ b/enterprise/web-frontend/modules/baserow_enterprise/components/assistant/AssistantSidebarItem.vue @@ -1,5 +1,5 @@