From 7d57852c7e944c223bae0735a02c8b2d36b41c07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Pardou?= <571533+jrmi@users.noreply.github.com> Date: Tue, 28 Oct 2025 15:49:35 +0100 Subject: [PATCH] Fix formula migration issue in get error messages (#4128) --- web-frontend/modules/builder/elementTypes.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/web-frontend/modules/builder/elementTypes.js b/web-frontend/modules/builder/elementTypes.js index f40acaed75..a81af4c123 100644 --- a/web-frontend/modules/builder/elementTypes.js +++ b/web-frontend/modules/builder/elementTypes.js @@ -1304,7 +1304,7 @@ export class HeadingElementType extends ElementType { * is empty to indicate an error, otherwise return false. */ getErrorMessage({ workspace, page, element, builder }) { - if (element.value.formula.length === 0) { + if (!element.value.formula) { return this.app.i18n.t('elementType.errorValueMissing') } return super.getErrorMessage({ @@ -1357,7 +1357,7 @@ export class TextElementType extends ElementType { * is empty to indicate an error, otherwise return false. */ getErrorMessage({ workspace, page, element, builder }) { - if (element.value.formula.length === 0) { + if (!element.value.formula) { return this.app.i18n.t('elementType.errorValueMissing') } return super.getErrorMessage({ @@ -1414,7 +1414,7 @@ export class LinkElementType extends ElementType { */ getErrorMessage({ workspace, page, element, builder }) { // A Link without any text isn't usable - if (element.value.formula.length === 0) { + if (!element.value.formula) { return this.app.i18n.t('elementType.errorValueMissing') } @@ -1577,7 +1577,7 @@ export class ButtonElementType extends ElementType { */ getErrorMessage({ workspace, page, element, builder }) { // If Button without any label should be considered invalid - if (element.value.formula.length === 0) { + if (!element.value.formula) { return this.app.i18n.t('elementType.errorValueMissing') }