From 6f409a7f325b8a00536d2054658e0736824c0266 Mon Sep 17 00:00:00 2001 From: Peter Evans Date: Fri, 12 Dec 2025 13:59:21 +0000 Subject: [PATCH] Improve the Local Baserow action form experience (#4340) * Working on improving the Local Baserow field mappings so that they clarify what data type they expect. We now also show the field's description, if it's set. * Removing the example, it was from a previous idea. * Re-adding the stylelint comment. --- ...row_action_fields_so_that_they_inform.json | 9 ++++++++ .../scss/components/formula_input_field.scss | 4 ++-- .../modules/core/components/FormGroup.vue | 4 ++-- .../components/formula/FormulaInputField.vue | 14 +++++------ web-frontend/modules/database/fieldTypes.js | 4 ++-- .../components/services/FieldMappingForm.vue | 23 +++++++++++++++---- .../modules/integrations/locales/en.json | 14 +++++++---- 7 files changed, 51 insertions(+), 21 deletions(-) create mode 100644 changelog/entries/unreleased/feature/improved_the_local_baserow_action_fields_so_that_they_inform.json diff --git a/changelog/entries/unreleased/feature/improved_the_local_baserow_action_fields_so_that_they_inform.json b/changelog/entries/unreleased/feature/improved_the_local_baserow_action_fields_so_that_they_inform.json new file mode 100644 index 0000000000..81bb258b69 --- /dev/null +++ b/changelog/entries/unreleased/feature/improved_the_local_baserow_action_fields_so_that_they_inform.json @@ -0,0 +1,9 @@ +{ + "type": "feature", + "message": "Improved the Local Baserow action fields so that they inform users about what data type they expect to receive.", + "issue_origin": "github", + "issue_number": null, + "domain": "integration", + "bullet_points": [], + "created_at": "2025-11-26" +} \ No newline at end of file diff --git a/web-frontend/modules/core/assets/scss/components/formula_input_field.scss b/web-frontend/modules/core/assets/scss/components/formula_input_field.scss index 1b3c5a2a9c..38082897e4 100644 --- a/web-frontend/modules/core/assets/scss/components/formula_input_field.scss +++ b/web-frontend/modules/core/assets/scss/components/formula_input_field.scss @@ -40,8 +40,8 @@ } /* stylelint-disable-next-line selector-class-pattern */ -.ProseMirror div.is-editor-empty:first-child::before { - content: attr(data-placeholder); +.formula-input-field--formula-empty .ProseMirror div:first-child::before { + content: var(--formula-placeholder); float: left; color: $palette-neutral-500; pointer-events: none; diff --git a/web-frontend/modules/core/components/FormGroup.vue b/web-frontend/modules/core/components/FormGroup.vue index ddd1236140..ed3947602f 100644 --- a/web-frontend/modules/core/components/FormGroup.vue +++ b/web-frontend/modules/core/components/FormGroup.vue @@ -116,7 +116,7 @@ export default { default: null, }, /** - * Wether the label should be displayed as a small label. + * Whether the label should be displayed as a small label. */ smallLabel: { type: Boolean, @@ -149,7 +149,7 @@ export default { default: false, }, /** - * Whether the label is required. (if false that will diplay an 'optional' label) + * Whether the label is required. (if false that will display an 'optional' label) */ required: { type: Boolean, diff --git a/web-frontend/modules/core/components/formula/FormulaInputField.vue b/web-frontend/modules/core/components/formula/FormulaInputField.vue index 6b7a2df0a6..cd3a4cb84e 100644 --- a/web-frontend/modules/core/components/formula/FormulaInputField.vue +++ b/web-frontend/modules/core/components/formula/FormulaInputField.vue @@ -9,6 +9,7 @@ role="textbox" :class="classes" :editor="editor" + :style="{ '--formula-placeholder': `'${placeholder}'` }" @data-node-clicked="dataNodeClicked" /> @@ -39,7 +40,6 @@