Commit b66235f
authored
fix: guard guided tour highlight against missing target elements (baserow#5378)
* fix: guard guided tour highlight against missing target elements
Resolves baserow#5377
* fix: hide highlight overlay when no target elements match
Toggle a separate `visible` flag instead of leaving `selector` set when
no elements match. Otherwise the .highlight div stays rendered with its
5000px dimming box-shadow over an empty 0×0 box, dimming the whole UI
without showing a target.
* fix: keep guided tour controls mounted when highlight has no target
Falling back to the centred position (the same path empty-selector steps
use) instead of unmounting the highlight root keeps the slot — including
GuidedTourStep's Next/Finish controls — visible, so users can always
advance or finish the tour.1 parent 0bda673 commit b66235f
2 files changed
Lines changed: 20 additions & 3 deletions
File tree
- changelog/entries/unreleased/bug
- web-frontend/modules/core/components
changelog/entries/unreleased/bug/fixes_a_guided_tour_crash_when_the_highlighted_element_is_no.json
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
48 | 53 | | |
49 | 54 | | |
50 | 55 | | |
| |||
110 | 115 | | |
111 | 116 | | |
112 | 117 | | |
113 | | - | |
114 | | - | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
115 | 122 | | |
116 | 123 | | |
117 | 124 | | |
118 | 125 | | |
119 | 126 | | |
120 | 127 | | |
121 | 128 | | |
| 129 | + | |
122 | 130 | | |
123 | 131 | | |
124 | 132 | | |
| |||
0 commit comments