Handle duplicate error gracefully for Page/Workflow rename (baserow#4271)

* Ensure that duplicate workflow name error is correctly handled

* Ensure that duplicate page name error is correctly handled

* Add builder changelog

* Remove dev-specific safety checks.

* Add automation changelog

Author: paljort

backend/src/baserow/contrib/automation/workflows/handler.py

@@ -46,6 +46,7 @@
 from baserow.contrib.automation.workflows.types import UpdatedAutomationWorkflow
 from baserow.core.cache import global_cache, local_cache
 from baserow.core.exceptions import IdDoesNotExist
+from baserow.core.psycopg import is_unique_violation_error
 from baserow.core.registries import ImportExportConfig
 from baserow.core.services.exceptions import DispatchException
 from baserow.core.storage import ExportZipFile, get_default_storage
@@ -247,7 +248,7 @@ def update_workflow(
         try:
             workflow.save()
         except IntegrityError as e:
-            if "unique constraint" in e.args[0] and "name" in e.args[0]:
+            if is_unique_violation_error(e) and "name" in str(e):
                 raise AutomationWorkflowNameNotUnique(
                     name=workflow.name, automation_id=workflow.automation_id
                 ) from e

backend/src/baserow/contrib/builder/pages/handler.py

@@ -42,6 +42,7 @@
 )
 from baserow.core.cache import global_cache
 from baserow.core.exceptions import IdDoesNotExist
+from baserow.core.psycopg import is_unique_violation_error
 from baserow.core.storage import ExportZipFile
 from baserow.core.user_sources.user_source_user import UserSourceUser
 from baserow.core.utils import ChildProgressBuilder, MirrorDict, find_unused_name
@@ -201,9 +202,9 @@ def update_page(self, page: Page, **kwargs) -> Page:
         try:
             page.save()
         except IntegrityError as e:
-            if "unique constraint" in e.args[0] and "name" in e.args[0]:
+            if is_unique_violation_error(e) and "name" in e.args[0]:
                 raise PageNameNotUnique(name=page.name, builder_id=page.builder_id)
-            if "unique constraint" in e.args[0] and "path" in e.args[0]:
+            if is_unique_violation_error(e) and "path" in e.args[0]:
                 raise PagePathNotUnique(path=page.path, builder_id=page.builder_id)
             raise e
 

backend/tests/baserow/contrib/automation/api/workflows/test_workflow_views.py

@@ -596,3 +596,26 @@ def test_get_workflow_history_permission_error(api_client, data_fixture):
         "detail": "You don't have the required permission to execute this operation.",
         "error": "PERMISSION_DENIED",
     }
+
+
+@pytest.mark.django_db
+def test_rename_workflow_using_existing_workflow_name(api_client, data_fixture):
+    user, token = data_fixture.create_user_and_token()
+    automation = data_fixture.create_automation_application(user)
+    workflow_1 = data_fixture.create_automation_workflow(
+        user, automation=automation, name="test1", order=1
+    )
+    workflow_2 = data_fixture.create_automation_workflow(
+        user, automation=automation, name="test2", order=2
+    )
+
+    url = reverse(API_URL_WORKFLOW_ITEM, kwargs={"workflow_id": workflow_2.id})
+    response = api_client.patch(
+        url,
+        {"name": workflow_1.name},
+        format="json",
+        HTTP_AUTHORIZATION=f"JWT {token}",
+    )
+
+    assert response.status_code == HTTP_400_BAD_REQUEST
+    assert response.json()["error"] == "ERROR_AUTOMATION_WORKFLOW_NAME_NOT_UNIQUE"

backend/tests/baserow/contrib/builder/api/pages/test_page_views.py

@@ -709,3 +709,24 @@ def test_delete_shared_page(api_client, data_fixture):
 
     assert response.status_code == HTTP_400_BAD_REQUEST
     assert response.json()["error"] == "ERROR_SHARED_PAGE_READ_ONLY"
+
+
+@pytest.mark.django_db
+def test_rename_page_using_existing_page_name(api_client, data_fixture):
+    user, token = data_fixture.create_user_and_token()
+    builder = data_fixture.create_builder_application(user=user)
+    page_1 = data_fixture.create_builder_page(builder=builder, order=1, name="test1")
+    page_2 = data_fixture.create_builder_page(builder=builder, order=1, name="test2")
+
+    url = reverse("api:builder:pages:item", kwargs={"page_id": page_2.id})
+    response = api_client.patch(
+        url,
+        {
+            "name": page_1.name,
+        },
+        format="json",
+        HTTP_AUTHORIZATION=f"JWT {token}",
+    )
+
+    assert response.status_code == HTTP_400_BAD_REQUEST
+    assert response.json()["error"] == "ERROR_PAGE_NAME_NOT_UNIQUE"

changelog/entries/unreleased/bug/4183_gracefully_handle_when_page_is_being_renamed_to_an_existing_.json

@@ -0,0 +1,9 @@
+{
+    "type": "bug",
+    "message": "Show a specific error when a page is being renamed to an existing page's name.",
+    "issue_origin": "github",
+    "issue_number": 4183,
+    "domain": "builder",
+    "bullet_points": [],
+    "created_at": "2025-11-17"
+}

changelog/entries/unreleased/bug/4183_show_a_specific_error_when_a_workflow_is_being_renamed_to_an.json

@@ -0,0 +1,9 @@
+{
+    "type": "bug",
+    "message": "Show a specific error when a workflow is being renamed to an existing workflow's name.",
+    "issue_origin": "github",
+    "issue_number": 4183,
+    "domain": "automation",
+    "bullet_points": [],
+    "created_at": "2025-12-08"
+}

web-frontend/modules/automation/locales/en.json

@@ -46,7 +46,8 @@
     "duplicatedTitle": "Workflow duplicated"
   },
   "automationWorkflowErrors": {
-    "errorNameNotUnique": "A workflow with this name already exists"
+    "errorNameNotUnique": "A workflow with this name already exists",
+    "errorNameNotUniqueDescription": "Please enter a unique name for the workflow"
   },
   "trashType": {
     "workflow": "workflow",

web-frontend/modules/automation/plugin.js

@@ -70,6 +70,12 @@ export default (context) => {
 
   registerRealtimeEvents(app.$realtime)
 
+  app.$clientErrorMap.setError(
+    'ERROR_AUTOMATION_WORKFLOW_NAME_NOT_UNIQUE',
+    app.i18n.t('automationWorkflowErrors.errorNameNotUnique'),
+    app.i18n.t('automationWorkflowErrors.errorNameNotUniqueDescription')
+  )
+
   store.registerModule('automationApplication', automationApplicationStore)
   store.registerModule('automationWorkflow', automationWorkflowStore)
   store.registerModule('automationWorkflowNode', automationWorkflowNodeStore)

web-frontend/modules/builder/locales/en.json

@@ -56,6 +56,7 @@
   },
   "pageErrors": {
     "errorNameNotUnique": "A page with this name already exists",
+    "errorNameNotUniqueDescription": "Please enter a unique name for the page",
     "errorPathNotUnique": "A path with this name already exists",
     "errorStartingSlash": "A path needs to start with a '/'",
     "errorValidPathCharacters": "The path contains invalid characters",

web-frontend/modules/builder/plugin.js

@@ -172,6 +172,12 @@ export default (context) => {
 
   registerRealtimeEvents(app.$realtime)
 
+  app.$clientErrorMap.setError(
+    'ERROR_PAGE_NAME_NOT_UNIQUE',
+    app.i18n.t('pageErrors.errorNameNotUnique'),
+    app.i18n.t('pageErrors.errorNameNotUniqueDescription')
+  )
+
   store.registerModule('page', pageStore)
   store.registerModule('element', elementStore)
   store.registerModule('domain', domainStore)