Migrate baserow formulas to object (baserow#4080)

* Iimplement the migration

* Further improvements to FormulaField. Introducing JSONFormulaField so that CollectionField.config works correctly. Updating so.. so many tests.

* Further backend tweaks. Found issues in builder and dashboard.

* Further backend tweaks to support the 'used properties' checks.

* Add support for view filter component placeholders. For now it just used in ViewFilterTypeText.

* Lots of frontend changes in AB/WA/Integrations to support the new formula object.

* Fix link resolution

* Re-create the migrations

* Improvements added to JSONFormulaField to support multiple formula properties. Fixing oh-so-many tests in builder, premium and database.

* Fixing frontend tests.

* Addressing AI field feedback, adding BaserowFormulaObjectSerializer

* Fixing e2e tests.

---------

Co-authored-by: peter_baserow <peter@baserow.io>

Author: bram2w

backend/src/baserow/contrib/automation/formula_importer.py

@@ -1,9 +1,9 @@
-from typing import Dict
+from typing import Dict, Union
 
 from baserow.contrib.automation.data_providers.registries import (
     automation_data_provider_type_registry,
 )
-from baserow.core.formula import get_parse_tree_for_formula
+from baserow.core.formula import BaserowFormulaObject, get_parse_tree_for_formula
 from baserow.core.services.formula_importer import BaserowFormulaImporter
 
 
@@ -18,7 +18,9 @@ def get_data_provider_type_registry(self):
         return automation_data_provider_type_registry
 
 
-def import_formula(formula: str, id_mapping: Dict[str, str], **kwargs) -> str:
+def import_formula(
+    formula: Union[str, BaserowFormulaObject], id_mapping: Dict[str, str], **kwargs
+) -> str:
     """
     When a formula is used in an automation, it must be migrated when we import it
     because it could contain IDs referencing other objects.
@@ -30,8 +32,11 @@ def import_formula(formula: str, id_mapping: Dict[str, str], **kwargs) -> str:
     :return: The updated path.
     """
 
-    if not formula:
-        return formula
+    # Figure out what our formula string is.
+    formula_str = formula if isinstance(formula, str) else formula["formula"]
 
-    tree = get_parse_tree_for_formula(formula)
+    if not formula_str:
+        return formula_str
+
+    tree = get_parse_tree_for_formula(formula_str)
     return AutomationFormulaImporter(id_mapping, **kwargs).visit(tree)

backend/src/baserow/contrib/builder/api/elements/serializers.py

@@ -264,7 +264,7 @@ def get_workflow_actions(self, obj: ElementsAndWorkflowActions):
 
 class PageParameterValueSerializer(serializers.Serializer):
     name = serializers.CharField()
-    value = FormulaSerializerField(allow_blank=True)
+    value = FormulaSerializerField()
 
 
 @extend_schema_serializer(exclude_fields=("config",))
@@ -363,7 +363,7 @@ class UpdateCollectionFieldSerializer(serializers.ModelSerializer):
         help_text=CollectionField._meta.get_field("type").help_text,
     )
 
-    value = FormulaSerializerField(allow_blank=True)
+    value = FormulaSerializerField()
 
 
 class ChoiceOptionSerializer(serializers.ModelSerializer):
@@ -408,8 +408,6 @@ class MenuItemSerializer(serializers.ModelSerializer):
     )
     navigate_to_url = FormulaSerializerField(
         help_text=LinkElement._meta.get_field("navigate_to_url").help_text,
-        default="",
-        allow_blank=True,
         required=False,
     )
     page_parameters = PageParameterValueSerializer(

backend/src/baserow/contrib/builder/elements/collection_field_types.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict, Generator, TypedDict, Union
+from typing import Any, Dict, Generator, TypedDict
 
 from django.core.validators import MinValueValidator
 
@@ -13,7 +13,7 @@
     FormulaSerializerField,
     OptionalFormulaSerializerField,
 )
-from baserow.core.formula.types import BaserowFormula
+from baserow.core.formula.types import BaserowFormulaObject
 from baserow.core.registry import Instance
 
 
@@ -24,16 +24,14 @@ class BooleanCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["value"]
 
     class SerializedDict(TypedDict):
-        value: bool
+        value: BaserowFormulaObject
 
     @property
     def serializer_field_overrides(self):
         return {
             "value": FormulaSerializerField(
                 help_text="The boolean value.",
                 required=False,
-                allow_blank=True,
-                default=False,
             ),
         }
 
@@ -45,7 +43,7 @@ class RatingCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["value"]
 
     class SerializedDict(TypedDict):
-        value: BaserowFormula
+        value: BaserowFormulaObject
         color: str
         rating_style: str
         max_value: int
@@ -56,8 +54,6 @@ def serializer_field_overrides(self):
             "value": FormulaSerializerField(
                 help_text="The rating value.",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
             "color": serializers.CharField(
                 help_text="The color of the rating.",
@@ -87,16 +83,14 @@ class TextCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["value"]
 
     class SerializedDict(TypedDict):
-        value: str
+        value: BaserowFormulaObject
 
     @property
     def serializer_field_overrides(self):
         return {
             "value": FormulaSerializerField(
                 help_text="The formula for the text.",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
         }
 
@@ -171,8 +165,6 @@ def serializer_field_overrides(self):
                 "link_name": FormulaSerializerField(
                     help_text="The formula for the link name.",
                     required=False,
-                    allow_blank=True,
-                    default="",
                 ),
                 "variant": serializers.ChoiceField(
                     choices=LinkElement.VARIANTS.choices,
@@ -238,24 +230,20 @@ class TagsCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["values"]
 
     class SerializedDict(TypedDict):
-        values: str
+        values: BaserowFormulaObject
         colors_is_formula: bool
-        colors: Union[BaserowFormula, str]
+        colors: BaserowFormulaObject
 
     @property
     def serializer_field_overrides(self):
         return {
             "values": FormulaSerializerField(
                 help_text="The formula for the tags values",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
             "colors": OptionalFormulaSerializerField(
                 help_text="The formula or value for the tags colors",
                 required=False,
-                allow_blank=True,
-                default="",
                 is_formula_field_name="colors_is_formula",
             ),
             "colors_is_formula": serializers.BooleanField(
@@ -291,16 +279,14 @@ class ButtonCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["label"]
 
     class SerializedDict(TypedDict):
-        label: str
+        label: BaserowFormulaObject
 
     @property
     def serializer_field_overrides(self):
         return {
             "label": FormulaSerializerField(
                 help_text="The string value.",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
         }
 
@@ -316,22 +302,18 @@ class ImageCollectionFieldType(CollectionFieldType):
     simple_formula_fields = ["src", "alt"]
 
     class SerializedDict(TypedDict):
-        src: BaserowFormula
-        alt: BaserowFormula
+        src: BaserowFormulaObject
+        alt: BaserowFormulaObject
 
     @property
     def serializer_field_overrides(self):
         return {
             "src": FormulaSerializerField(
                 help_text="A link to the image file",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
             "alt": FormulaSerializerField(
                 help_text="A brief text description of the image",
                 required=False,
-                allow_blank=True,
-                default="",
             ),
         }