duration lookup filters (baserow#4140)

* duration lookup filters

Author: cezary-baserow

backend/src/baserow/contrib/database/apps.py

@@ -477,14 +477,14 @@ def ready(self):
             HasNotValueHigherThanFilterType,
             HasNotValueLowerOrEqualTHanFilterType,
             HasNotValueLowerThanFilterType,
+            HasValueComparableToFilter,
             HasValueContainsViewFilterType,
             HasValueContainsWordViewFilterType,
             HasValueEqualViewFilterType,
             HasValueHigherOrEqualThanFilter,
             HasValueLengthIsLowerThanViewFilterType,
             HasValueLowerOrEqualThanFilter,
             HasValueLowerThanFilter,
-            hasValueComparableToFilter,
         )
 
         view_filter_type_registry.register(HasValueEqualViewFilterType())
@@ -501,7 +501,7 @@ def ready(self):
         view_filter_type_registry.register(HasNoneSelectOptionEqualViewFilterType())
         view_filter_type_registry.register(HasValueLowerThanFilter())
         view_filter_type_registry.register(HasValueLowerOrEqualThanFilter())
-        view_filter_type_registry.register(hasValueComparableToFilter())
+        view_filter_type_registry.register(HasValueComparableToFilter())
         view_filter_type_registry.register(HasValueHigherOrEqualThanFilter())
         view_filter_type_registry.register(HasNotValueHigherOrEqualTHanFilterType())
         view_filter_type_registry.register(HasNotValueHigherThanFilterType())

backend/src/baserow/contrib/database/formula/expression_generator/django_expressions.py

@@ -269,3 +269,42 @@ def get_template_data(self, sql_value) -> dict:
         data = super().get_template_data(sql_value)
         data["comparison_op"] = self.comparison_op.value
         return data
+
+
+class JSONArrayCompareIntervalValueExpr(BaserowFilterExpression):
+    """
+    Base class for expressions that compare an interval value in a JSON array.
+    Together with the field_name and value, a comparison operator must be provided to be
+    used in the template.
+    """
+
+    def __init__(
+        self,
+        field_name: F,
+        value: Value,
+        comparison_op: ComparisonOperator,
+        output_field: Field,
+    ):
+        super().__init__(field_name, value, output_field)
+        if not isinstance(comparison_op, ComparisonOperator):
+            raise ValueError(
+                f"comparison_op must be a ComparisonOperator, not {type(comparison_op)}"
+            )
+        self.comparison_op = comparison_op
+
+    # fmt: off
+    template = (
+        f"""
+            EXISTS(
+                SELECT 1
+                FROM JSONB_ARRAY_ELEMENTS(%(field_name)s) as filtered_field
+                WHERE (filtered_field ->> 'value')::interval %(comparison_op)s make_interval(secs=>%(value)s)
+            )
+            """  # nosec B608 %(value)s %(comparison_op)s
+    )
+    # fmt: on
+
+    def get_template_data(self, sql_value) -> dict:
+        data = super().get_template_data(sql_value)
+        data["comparison_op"] = self.comparison_op.value
+        return data

backend/src/baserow/contrib/database/formula/types/formula_types.py

@@ -60,6 +60,7 @@
 )
 from baserow.contrib.database.formula.expression_generator.django_expressions import (
     ComparisonOperator,
+    JSONArrayCompareIntervalValueExpr,
     JSONArrayCompareNumericValueExpr,
 )
 from baserow.contrib.database.formula.registries import formula_function_registry
@@ -813,6 +814,31 @@ def get_order_by_in_array_expr(self, field, field_name, order_direction):
             field_name, "value", "interval", output_field=models.DurationField()
         )
 
+    def get_has_numeric_value_comparable_to_filter_query(
+        self,
+        field_name: str,
+        value: str,
+        model_field: models.Field,
+        field: "Field",
+        comparison_op: ComparisonOperator,
+    ) -> "OptionallyAnnotatedQ":
+        try:
+            value = int(value)
+        except (TypeError, ValueError):
+            return Q()
+
+        return get_array_json_filter_expression(
+            JSONArrayCompareIntervalValueExpr,
+            field_name,
+            Value(value),
+            comparison_op=comparison_op,
+        )
+
+    def get_in_array_is_query(self, field_name, value, model_field, field):
+        return self.get_has_numeric_value_comparable_to_filter_query(
+            field_name, value, model_field, field, ComparisonOperator.EQUAL
+        )
+
 
 class BaserowFormulaDateType(
     HasValueEmptyFilterSupport, HasValueContainsFilterSupport, BaserowFormulaValidType

backend/src/baserow/contrib/database/views/array_view_filters.py

@@ -29,6 +29,7 @@
     BaserowFormulaBooleanType,
     BaserowFormulaCharType,
     BaserowFormulaDateType,
+    BaserowFormulaDurationType,
     BaserowFormulaMultipleSelectType,
     BaserowFormulaSingleSelectType,
     BaserowFormulaURLType,
@@ -55,6 +56,7 @@ class HasEmptyValueViewFilterType(ViewFilterType):
             FormulaFieldType.array_of(BaserowFormulaNumberType.type),
             FormulaFieldType.array_of(BaserowFormulaMultipleSelectType.type),
             FormulaFieldType.array_of(BaserowFormulaMultipleCollaboratorsType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]
 
@@ -124,6 +126,7 @@ class HasValueEqualViewFilterType(ComparisonHasValueFilter):
             FormulaFieldType.array_of(BaserowFormulaNumberType.type),
             FormulaFieldType.array_of(BaserowFormulaMultipleSelectType.type),
             FormulaFieldType.array_of(BaserowFormulaMultipleCollaboratorsType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]
 
@@ -287,11 +290,12 @@ class HasNoneSelectOptionEqualViewFilterType(
     type = "has_none_select_option_equal"
 
 
-class hasValueComparableToFilter(ComparisonHasValueFilter):
+class HasValueComparableToFilter(ComparisonHasValueFilter):
     type = "has_value_higher"
     compatible_field_types = [
         FormulaFieldType.compatible_with_formula_types(
-            FormulaFieldType.array_of(BaserowFormulaNumberType.type)
+            FormulaFieldType.array_of(BaserowFormulaNumberType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]
 
@@ -305,7 +309,7 @@ def get_filter_expression(self, field_name, value, model_field, field):
 
 
 class HasNotValueHigherThanFilterType(
-    NotViewFilterTypeMixin, hasValueComparableToFilter
+    NotViewFilterTypeMixin, HasValueComparableToFilter
 ):
     type = "has_not_value_higher"
 
@@ -314,7 +318,8 @@ class HasValueHigherOrEqualThanFilter(ComparisonHasValueFilter):
     type = "has_value_higher_or_equal"
     compatible_field_types = [
         FormulaFieldType.compatible_with_formula_types(
-            FormulaFieldType.array_of(BaserowFormulaNumberType.type)
+            FormulaFieldType.array_of(BaserowFormulaNumberType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]
 
@@ -341,7 +346,8 @@ class HasValueLowerThanFilter(ComparisonHasValueFilter):
     type = "has_value_lower"
     compatible_field_types = [
         FormulaFieldType.compatible_with_formula_types(
-            FormulaFieldType.array_of(BaserowFormulaNumberType.type)
+            FormulaFieldType.array_of(BaserowFormulaNumberType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]
 
@@ -362,7 +368,8 @@ class HasValueLowerOrEqualThanFilter(ComparisonHasValueFilter):
     type = "has_value_lower_or_equal"
     compatible_field_types = [
         FormulaFieldType.compatible_with_formula_types(
-            FormulaFieldType.array_of(BaserowFormulaNumberType.type)
+            FormulaFieldType.array_of(BaserowFormulaNumberType.type),
+            FormulaFieldType.array_of(BaserowFormulaDurationType.type),
         ),
     ]