Don't validate formula parameter value (baserow#4207)

Author: jrmi

web-frontend/modules/core/formula/index.js

@@ -41,7 +41,8 @@ export const isFormulaValid = (formula, functions) => {
 
   try {
     const tree = parseBaserowFormula(formula)
-    new JavascriptExecutor(functions).visit(tree)
+    // we don't validate type as we can't without the right context
+    new JavascriptExecutor(functions, {}, false).visit(tree)
     return true
   } catch (err) {
     return false

web-frontend/modules/core/formula/parser/javascriptExecutor.js

@@ -12,10 +12,11 @@ export class FunctionCollection {
 }
 
 export default class JavascriptExecutor extends BaserowFormulaVisitor {
-  constructor(functions, context = {}) {
+  constructor(functions, context = {}, validateArgsType = true) {
     super()
     this.functions = functions
     this.context = context
+    this.validateArgsType = validateArgsType
   }
 
   visitRoot(ctx) {
@@ -65,7 +66,7 @@ export default class JavascriptExecutor extends BaserowFormulaVisitor {
 
     const formulaFunctionType = this.functions.get(functionName)
 
-    formulaFunctionType.validateArgs(args)
+    formulaFunctionType.validateArgs(args, this.validateArgsType)
 
     const argsParsed = formulaFunctionType.parseArgs(args)
 

web-frontend/modules/core/runtimeFormulaTypes.js

@@ -71,13 +71,15 @@ export class RuntimeFormulaFunction extends Registerable {
    * @throws InvalidNumberOfArguments - If the number of arguments is incorrect
    * @throws InvalidFormulaArgumentType - If any of the arguments have a wrong type
    */
-  validateArgs(args) {
+  validateArgs(args, validateType = true) {
     if (!this.validateNumberOfArgs(args)) {
       throw new InvalidNumberOfArguments(this, args)
     }
-    const invalidArg = this.validateTypeOfArgs(args)
-    if (invalidArg) {
-      throw new InvalidFormulaArgumentType(this, invalidArg)
+    if (validateType) {
+      const invalidArg = this.validateTypeOfArgs(args)
+      if (invalidArg) {
+        throw new InvalidFormulaArgumentType(this, invalidArg)
+      }
     }
   }
 

web-frontend/modules/core/utils/validator.js

@@ -185,7 +185,7 @@ export const ensureNonEmptyString = (value, options) => {
  * @param {boolean} useStrict - Whether to be strict in how the value is interpreted.
  * @returns {boolean} The value as a boolean.
  */
-export const ensureBoolean = (value, { useStrict = true }) => {
+export const ensureBoolean = (value, { useStrict = true } = {}) => {
   if (trueValues.includes(value)) {
     return true
   } else if (falseValues.includes(value)) {