Removed database FF, added changelog entries (baserow#4275)

silvestrid · web-flow · commit 2466bf02446d · 2025-11-17T20:02:58.000+01:00
diff --git a/backend/src/baserow/api/search/urls.py b/backend/src/baserow/api/search/urls.py
@@ -1,17 +1,13 @@
 from django.urls import path
 
 from baserow.api.search.views import WorkspaceSearchView
-from baserow.core.feature_flags import FF_WORKSPACE_SEARCH, feature_flag_is_enabled
 
 app_name = "baserow.api.search"
 
-urlpatterns = []
-
-if feature_flag_is_enabled(FF_WORKSPACE_SEARCH):
-    urlpatterns = [
-        path(
-            "workspace/<int:workspace_id>/",
-            WorkspaceSearchView.as_view(),
-            name="workspace_search",
-        ),
-    ]
+urlpatterns = [
+    path(
+        "workspace/<int:workspace_id>/",
+        WorkspaceSearchView.as_view(),
+        name="workspace_search",
+    ),
+]
diff --git a/backend/src/baserow/contrib/database/api/field_rules/urls.py b/backend/src/baserow/contrib/database/api/field_rules/urls.py
@@ -1,24 +1,20 @@
 from django.urls import re_path
 
-from baserow.core.feature_flags import FF_DATE_DEPENDENCY, feature_flag_is_enabled
+from .views import FieldRulesView, FieldRuleView, InvalidRowsView
 
 app_name = "baserow.contrib.database.api.field_rules"
 
-urlpatterns = []
 
-if feature_flag_is_enabled(FF_DATE_DEPENDENCY):
-    from .views import FieldRulesView, FieldRuleView, InvalidRowsView
-
-    urlpatterns += [
-        re_path(r"^(?P<table_id>[0-9]+)/$", FieldRulesView.as_view(), name="list"),
-        re_path(
-            r"^(?P<table_id>[0-9]+)/rule/(?P<rule_id>[0-9]+)/$",
-            FieldRuleView.as_view(),
-            name="item",
-        ),
-        re_path(
-            r"^(?P<table_id>[0-9]+)/invalid-rows/$",
-            InvalidRowsView.as_view(),
-            name="invalid_rows",
-        ),
-    ]
+urlpatterns = [
+    re_path(r"^(?P<table_id>[0-9]+)/$", FieldRulesView.as_view(), name="list"),
+    re_path(
+        r"^(?P<table_id>[0-9]+)/rule/(?P<rule_id>[0-9]+)/$",
+        FieldRuleView.as_view(),
+        name="item",
+    ),
+    re_path(
+        r"^(?P<table_id>[0-9]+)/invalid-rows/$",
+        InvalidRowsView.as_view(),
+        name="invalid_rows",
+    ),
+]
diff --git a/backend/src/baserow/contrib/database/field_rules/handlers.py b/backend/src/baserow/contrib/database/field_rules/handlers.py
@@ -15,7 +15,6 @@
 from baserow.contrib.database.table.cache import clear_generated_model_cache
 from baserow.contrib.database.table.models import GeneratedTableModel, Table
 from baserow.core.db import specific_iterator
-from baserow.core.feature_flags import FF_DATE_DEPENDENCY, feature_flag_is_enabled
 
 from .collector import FieldRuleCollector
 from .exceptions import FieldRuleTableMismatch, NoRuleError
@@ -50,8 +49,6 @@ def has_field_rules(self) -> bool:
         Returns `True` if the table contains active field rules.
         """
 
-        if not feature_flag_is_enabled(FF_DATE_DEPENDENCY):
-            return False
         if not self.table.field_rules_validity_column_added:
             return False
         return bool(self.applicable_rules_with_types)
diff --git a/backend/src/baserow/core/feature_flags.py b/backend/src/baserow/core/feature_flags.py
@@ -2,8 +2,6 @@
 
 from baserow.core.exceptions import FeatureDisabledException
 
-FF_WORKSPACE_SEARCH = "workspace-search"
-FF_DATE_DEPENDENCY = "date_dependency"
 FF_ENABLE_ALL = "*"
 
 
diff --git a/changelog/entries/unreleased/feature/3826_workspace_search.json b/changelog/entries/unreleased/feature/3826_workspace_search.json
@@ -0,0 +1,9 @@
+{
+    "type": "feature",
+    "message": "Workspace search",
+    "issue_origin": "github",
+    "issue_number": 3826,
+    "domain": "database",
+    "bullet_points": [],
+    "created_at": "2025-11-17"
+}
diff --git a/changelog/entries/unreleased/feature/3829_date_dependencies_in_table.json b/changelog/entries/unreleased/feature/3829_date_dependencies_in_table.json
@@ -0,0 +1,9 @@
+{
+    "type": "feature",
+    "message": "Date dependencies in table",
+    "issue_origin": "github",
+    "issue_number": 3829,
+    "domain": "database",
+    "bullet_points": [],
+    "created_at": "2025-11-17"
+}
diff --git a/enterprise/web-frontend/modules/baserow_enterprise/components/dateDependency/DateDependencyMenuItem.vue b/enterprise/web-frontend/modules/baserow_enterprise/components/dateDependency/DateDependencyMenuItem.vue
@@ -1,6 +1,6 @@
 <template>
   <div
-    v-if="showEntry && featureFlagEnabled && (hasPermission || !hasFeature)"
+    v-if="showEntry && (hasPermission || !hasFeature)"
     class="context__menu-item"
   >
     <div>
@@ -43,7 +43,6 @@
 import EnterpriseFeatures from '@baserow_enterprise/features'
 import PaidFeaturesModal from '@baserow_premium/components/PaidFeaturesModal'
 import DateDependencyModal from '@baserow_enterprise/components/dateDependency/DateDependencyModal'
-import { FF_DATE_DEPENDENCY } from '@baserow/modules/core/plugins/featureFlags'
 
 export default {
   name: 'DateDependencyMenuItem',
@@ -76,9 +75,6 @@ export default {
         this.database.workspace.id
       )
     },
-    featureFlagEnabled() {
-      return this.$featureFlagIsEnabled(FF_DATE_DEPENDENCY)
-    },
     hasPermission() {
       return this.$hasPermission(
         'database.table.field_rules.set_field_rules',
diff --git a/enterprise/web-frontend/modules/baserow_enterprise/dateDependencyTypes.js b/enterprise/web-frontend/modules/baserow_enterprise/dateDependencyTypes.js
@@ -2,7 +2,6 @@ import _ from 'lodash'
 import { Registerable } from '@baserow/modules/core/registry'
 import DateDependencyMenuItem from '@baserow_enterprise/components/dateDependency/DateDependencyMenuItem'
 import TimelineFieldRuleType from '@baserow_premium/timelineFieldRuleType'
-import { FF_DATE_DEPENDENCY } from '@baserow/modules/core/plugins/featureFlags'
 import DateDependencyConnection from '@baserow_enterprise/components/dateDependency/DateDependencyConnection'
 
 // Date dependency on timeline views
@@ -104,7 +103,6 @@ export class DateDependencyTimelineComponent extends TimelineFieldRuleType {
 
   getTimelineFieldRuleComponent(rule, view, database) {
     if (
-      this.app.$featureFlagIsEnabled(FF_DATE_DEPENDENCY) &&
       this.app.$hasPermission(
         'database.table.field_rules.read_field_rules',
         view.table,
diff --git a/enterprise/web-frontend/modules/baserow_enterprise/plugin.js b/enterprise/web-frontend/modules/baserow_enterprise/plugin.js
@@ -88,7 +88,6 @@ import {
 } from '@baserow_enterprise/dateDependencyTypes'
 import { CustomCodeBuilderSettingType } from '@baserow_enterprise/builderSettingTypes'
 import { RealtimePushTwoWaySyncStrategyType } from '@baserow_enterprise/twoWaySyncStrategyTypes'
-import { FF_DATE_DEPENDENCY } from '@baserow/modules/core/plugins/featureFlags'
 
 export default (context) => {
   const { app, isDev, store } = context
@@ -240,16 +239,11 @@ export default (context) => {
     new BuilderFileInputElementPaidFeature(context)
   )
 
-  if (app.$featureFlagIsEnabled(FF_DATE_DEPENDENCY)) {
-    app.$registry.register(
-      'paidFeature',
-      new DateDependencyPaidFeature(context)
-    )
-    app.$registry.register(
-      'timelineFieldRules',
-      new DateDependencyTimelineComponent(context)
-    )
-  }
+  app.$registry.register('paidFeature', new DateDependencyPaidFeature(context))
+  app.$registry.register(
+    'timelineFieldRules',
+    new DateDependencyTimelineComponent(context)
+  )
   app.$registry.register(
     'fieldContextItem',
     new DateDependencyContextItemType(context)
diff --git a/web-frontend/modules/core/components/sidebar/SidebarMenu.vue b/web-frontend/modules/core/components/sidebar/SidebarMenu.vue
@@ -2,7 +2,6 @@
   <div class="sidebar__section" ph-autocapture="sidebar" data-highlight="menu">
     <ul class="tree">
       <SidebarSearch
-        v-if="$featureFlagIsEnabled(FF_WORKSPACE_SEARCH)"
         :selected-workspace="selectedWorkspace"
         @open-workspace-search="openWorkspaceSearch"
       />
@@ -151,7 +150,6 @@
 <script>
 import { mapGetters } from 'vuex'
 
-import { FF_WORKSPACE_SEARCH } from '@baserow/modules/core/plugins/featureFlags'
 import TrashModal from '@baserow/modules/core/components/trash/TrashModal'
 import NotificationPanel from '@baserow/modules/core/components/NotificationPanel'
 import WorkspaceMemberInviteModal from '@baserow/modules/core/components/workspace/WorkspaceMemberInviteModal'
@@ -178,11 +176,6 @@ export default {
       default: false,
     },
   },
-  data() {
-    return {
-      FF_WORKSPACE_SEARCH,
-    }
-  },
   computed: {
     sidebarWorkspaceComponents() {
       return Object.values(this.$registry.getAll('plugin'))
diff --git a/web-frontend/modules/core/layouts/app.vue b/web-frontend/modules/core/layouts/app.vue
@@ -55,17 +55,13 @@
         :key="index"
       ></component>
     </div>
-    <WorkspaceSearchModal
-      v-if="$featureFlagIsEnabled(FF_WORKSPACE_SEARCH)"
-      ref="workspaceSearchModal"
-    ></WorkspaceSearchModal>
+    <WorkspaceSearchModal ref="workspaceSearchModal"></WorkspaceSearchModal>
   </div>
 </template>
 
 <script>
 import { mapGetters, mapState } from 'vuex'
 
-import { FF_WORKSPACE_SEARCH } from '@baserow/modules/core/plugins/featureFlags'
 import Toasts from '@baserow/modules/core/components/toasts/Toasts'
 import Sidebar from '@baserow/modules/core/components/sidebar/Sidebar'
 import RightSidebar from '@baserow/modules/core/components/sidebar/RightSidebar'
@@ -100,7 +96,6 @@ export default {
       col1Width: 240,
       col3Width: 400,
       col3Visible: false,
-      FF_WORKSPACE_SEARCH,
     }
   },
   computed: {
@@ -169,11 +164,7 @@ export default {
   methods: {
     keyDown(event) {
       // Handle workspace search shortcut (Ctrl/Cmd + K) - only if feature enabled
-      if (
-        (event.ctrlKey || event.metaKey) &&
-        event.key.toLowerCase() === 'k' &&
-        this.$featureFlagIsEnabled(FF_WORKSPACE_SEARCH)
-      ) {
+      if ((event.ctrlKey || event.metaKey) && event.key.toLowerCase() === 'k') {
         event.preventDefault()
         this.openWorkspaceSearch()
         return
@@ -200,11 +191,7 @@ export default {
     },
 
     openWorkspaceSearch() {
-      if (
-        this.selectedWorkspace &&
-        this.$refs.workspaceSearchModal &&
-        this.$featureFlagIsEnabled(FF_WORKSPACE_SEARCH)
-      ) {
+      if (this.selectedWorkspace && this.$refs.workspaceSearchModal) {
         this.$refs.workspaceSearchModal.show()
       }
     },
diff --git a/web-frontend/modules/core/plugins/featureFlags.js b/web-frontend/modules/core/plugins/featureFlags.js
@@ -1,6 +1,4 @@
 const FF_ENABLE_ALL = '*'
-export const FF_WORKSPACE_SEARCH = 'workspace-search'
-export const FF_DATE_DEPENDENCY = 'date_dependency'
 
 /**
  * A comma separated list of feature flags used to enable in-progress or not ready
diff --git a/web-frontend/modules/database/viewTypes.js b/web-frontend/modules/database/viewTypes.js
@@ -18,7 +18,6 @@ import { clone } from '@baserow/modules/core/utils/object'
 import { getDefaultSearchModeFromEnv } from '@baserow/modules/database/utils/search'
 import { GRID_VIEW_SIZE_TO_ROW_HEIGHT_MAPPING } from '@baserow/modules/database/constants'
 import { waitFor } from '@baserow/modules/core/utils/queue'
-import { FF_DATE_DEPENDENCY } from '@baserow/modules/core/plugins/featureFlags'
 
 export const maxPossibleOrderValue = 32767
 
@@ -581,7 +580,6 @@ export class GridViewType extends ViewType {
     )
 
     if (
-      this.app.$featureFlagIsEnabled(FF_DATE_DEPENDENCY) &&
       !isPublic &&
       this.app.$hasPermission(
         'database.table.field_rules.read_field_rules',
@@ -899,7 +897,6 @@ export const BaseBufferedRowViewTypeMixin = (Base) =>
       )
 
       if (
-        this.app.$featureFlagIsEnabled(FF_DATE_DEPENDENCY) &&
         !isPublic &&
         this.app.$hasPermission(
           'database.table.field_rules.read_field_rules',
