Fix CSV import throwing 'no fetchall attribute' error and respect primary field order (baserow#4165)

Fix CSV import throwing 'no fetchall attribute' error and respect primary field order

Author: dimmur-brw

backend/src/baserow/contrib/database/rows/handler.py

@@ -1808,8 +1808,8 @@ def import_rows(
             and not field_object["field"].read_only
         ]
 
-        # Sort by order then by id
-        fields.sort(key=lambda f: (f.order, f.id))
+        # Sort by primary first (descending), then by order, then by id
+        fields.sort(key=lambda f: (not f.primary, f.order, f.id))
 
         for index, row in enumerate(data):
             # Check row length

backend/src/baserow/contrib/database/table/queryset.py

@@ -22,6 +22,8 @@ def _as_sql():
 
     def execute_sql(self, result_type):
         cursor = super(SQLUpdateCompiler, self).execute_sql(result_type)
+        if cursor is None:
+            return []
         return [res[0] for res in cursor.fetchall()]
 
 

backend/tests/baserow/contrib/database/rows/test_rows_actions.py

@@ -1313,3 +1313,61 @@ def test_can_undo_redo_update_rows_interesting_field_types(data_fixture):
         )
     ) == [multi_select_option_2.id]
     assert getattr(row_table_1, f"field_{formula_field.id}") == "New value"
+
+
+@pytest.mark.django_db(transaction=True)
+def test_import_rows_respects_primary_priority_sorting(data_fixture):
+    user = data_fixture.create_user()
+    database = data_fixture.create_database_application(
+        user=user, name="Sample database"
+    )
+    table = data_fixture.create_database_table(database=database, name="Sample table")
+
+    single_select = data_fixture.create_single_select_field(
+        table=table, name="Single select", order=4, primary=False
+    )
+    data_fixture.create_select_option(
+        field=single_select, value="A", color="dark-green", order=0
+    )
+    data_fixture.create_select_option(
+        field=single_select, value="B", color="light-blue", order=1
+    )
+
+    name_field = data_fixture.create_text_field(
+        table=table, name="Name", order=5, primary=True
+    )
+
+    text_field = data_fixture.create_text_field(
+        table=table, name="Text", order=8, primary=False
+    )
+
+    data_fixture.create_formula_field(
+        table=table,
+        name="Formula",
+        order=58,
+        formula="field('Text')",
+        formula_type="text",
+        internal_formula="field('Text')",
+        nullable=True,
+        recalculate=True,
+    )
+
+    data = [["N", "A", "text"]]
+
+    created_rows, error_report = ImportRowsActionType.do(
+        user,
+        table,
+        data={"data": data, "configuration": None},
+        progress=None,
+    )
+
+    assert error_report == {}
+    assert len(created_rows) == 1
+
+    row = created_rows[0]
+    model = table.get_model()
+    stored = model.objects.get(id=row.id)
+
+    assert getattr(stored, name_field.db_column) == "N"
+    assert getattr(stored, text_field.db_column) == "text"
+    assert getattr(stored, single_select.db_column).value == "A"

changelog/entries/unreleased/bug/4163_fix_csv_import_throwing_no_fetchall_attribute_error_and_respect_pr.json

@@ -0,0 +1,8 @@
+{
+    "type": "bug",
+    "message": "Fix CSV import throwing 'no fetchall attribute' error and respect primary field order",
+    "domain": "database",
+    "issue_number": 4163,
+    "bullet_points": [],
+    "created_at": "2025-11-05"
+}