Ensure simulate_until_node_is reset when node is replaced. (baserow#4249)

* Ensure simulate_until_node_is reset when node is replaced.

* Set simulate_until_node_id to null instead of refreshing entire workflow

Author: paljort

backend/src/baserow/contrib/automation/nodes/service.py

@@ -400,6 +400,10 @@ def replace_node(
 
         workflow.get_graph().replace(node_to_replace, new_node)
 
+        if workflow.simulate_until_node_id == node_to_replace.id:
+            workflow.simulate_until_node = None
+            workflow.save(update_fields=["simulate_until_node"])
+
         automation_node_deleted.send(
             self,
             workflow=workflow,

backend/tests/baserow/contrib/automation/nodes/test_node_actions.py

@@ -109,7 +109,10 @@ def test_replace_automation_action_node_type(data_fixture):
     node = data_fixture.create_automation_node(
         workflow=workflow, type=LocalBaserowCreateRowNodeType.type, label="To replace"
     )
-    node_after = data_fixture.create_automation_node(
+    workflow.simulate_until_node_id = node.id
+    workflow.save()
+
+    data_fixture.create_automation_node(
         workflow=workflow, type=LocalBaserowCreateRowNodeType.type, label="After"
     )
 
@@ -126,6 +129,9 @@ def test_replace_automation_action_node_type(data_fixture):
         user, node.id, LocalBaserowUpdateRowNodeType.type
     )
 
+    workflow.refresh_from_db()
+    assert workflow.simulate_until_node_id is None
+
     workflow.assert_reference(
         {
             "0": "local_baserow_rows_created",
@@ -209,10 +215,12 @@ def test_replace_automation_trigger_node_type(data_fixture):
     automation = data_fixture.create_automation_application(workspace=workspace)
     workflow = data_fixture.create_automation_workflow(user, automation=automation)
     original_trigger = workflow.get_trigger()
-    action_node = data_fixture.create_automation_node(
+    data_fixture.create_automation_node(
         workflow=workflow,
         type=LocalBaserowCreateRowNodeType.type,
     )
+    workflow.simulate_until_node_id = original_trigger.id
+    workflow.save()
 
     workflow.assert_reference(
         {
@@ -226,6 +234,9 @@ def test_replace_automation_trigger_node_type(data_fixture):
         user, original_trigger.id, LocalBaserowRowsUpdatedNodeTriggerType.type
     )
 
+    workflow.refresh_from_db()
+    assert workflow.simulate_until_node_id is None
+
     workflow.assert_reference(
         {
             "0": "local_baserow_rows_updated",

web-frontend/modules/automation/store/automationWorkflowNode.js

@@ -342,7 +342,10 @@ const actions = {
       throw error
     }
   },
-  async replace({ commit, dispatch, getters }, { workflow, nodeId, newType }) {
+  async replace(
+    { commit, dispatch, getters, rootGetters },
+    { workflow, nodeId, newType }
+  ) {
     const nodeToReplace = getters.findById(workflow, nodeId)
 
     const { data: newNode } = await AutomationWorkflowNodeService(
@@ -361,6 +364,15 @@ const actions = {
 
     commit('DELETE_ITEM', { workflow, nodeId })
 
+    await dispatch(
+      'automationWorkflow/forceUpdate',
+      {
+        workflow,
+        values: { simulate_until_node_id: null },
+      },
+      { root: true }
+    )
+
     setTimeout(() => {
       dispatch('select', { workflow, node: newNode })
     })