Return proper error when creating autonumber field with form view (baserow#4646)

Author: stribny

backend/src/baserow/contrib/database/api/fields/errors.py

@@ -214,3 +214,8 @@
     HTTP_400_BAD_REQUEST,
     "Cannot set this constraint when default value is set.",
 )
+ERROR_VIEW_NOT_SUPPORTED = (
+    "ERROR_VIEW_NOT_SUPPORTED",
+    HTTP_400_BAD_REQUEST,
+    "Cannot use the view type.",
+)

backend/src/baserow/contrib/database/api/fields/views.py

@@ -59,6 +59,7 @@
     ERROR_RESERVED_BASEROW_FIELD_NAME,
     ERROR_SELECT_OPTION_DOES_NOT_BELONG_TO_FIELD,
     ERROR_TABLE_HAS_NO_PRIMARY_FIELD,
+    ERROR_VIEW_NOT_SUPPORTED,
 )
 from baserow.contrib.database.api.rows.errors import ERROR_ROW_DOES_NOT_EXIST
 from baserow.contrib.database.api.tables.errors import (
@@ -118,6 +119,7 @@
 from baserow.contrib.database.table.handler import TableHandler
 from baserow.contrib.database.tokens.exceptions import NoPermissionToTable
 from baserow.contrib.database.tokens.handler import TokenHandler
+from baserow.contrib.database.views.exceptions import ViewDoesNotSupportListingRows
 from baserow.core.action.registries import action_type_registry
 from baserow.core.db import atomic_with_retry_on_deadlock, specific_iterator
 from baserow.core.exceptions import UserNotInWorkspace
@@ -295,6 +297,7 @@ def get(self, request, table_id):
             InvalidFieldConstraint: ERROR_INVALID_FIELD_CONSTRAINT,
             ImmutableFieldProperties: ERROR_IMMUTABLE_FIELD_PROPERTIES,
             FieldConstraintDoesNotSupportDefaultValueError: ERROR_FIELD_CONSTRAINT_DOES_NOT_SUPPORT_DEFAULT_VALUE,
+            ViewDoesNotSupportListingRows: ERROR_VIEW_NOT_SUPPORTED,
         }
     )
     def post(self, request, data, table_id):

backend/tests/baserow/contrib/database/api/fields/test_field_views_types.py

@@ -1840,3 +1840,25 @@ def test_lookup_field_type(api_client, data_fixture):
     response_json = response.json()
     assert response.status_code == HTTP_400_BAD_REQUEST
     assert response_json["error"] == "ERROR_REQUEST_BODY_VALIDATION"
+
+
+@pytest.mark.django_db
+def test_autonumber_field_type_create_fails_form_view(api_client, data_fixture):
+    user, token = data_fixture.create_user_and_token()
+    table = data_fixture.create_database_table(user=user)
+    view = data_fixture.create_form_view(user=user, table=table)
+
+    response = api_client.post(
+        reverse("api:database:fields:list", kwargs={"table_id": table.id}),
+        {
+            "name": "autonumber_field",
+            "type": "autonumber",
+            "view_id": view.id,
+        },
+        format="json",
+        HTTP_AUTHORIZATION=f"JWT {token}",
+    )
+
+    response_json = response.json()
+    assert response.status_code == HTTP_400_BAD_REQUEST, response_json
+    assert response_json["error"] == "ERROR_VIEW_NOT_SUPPORTED"