Skip to content

Commit a0a97eb

Browse files
authored
chore: move dp cluster to traefik (appsmithorg#41600)
## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR. <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Enhanced deployment reliability by implementing graceful service shutdown before cleanup operations in the recreation flow. * Updated ingress controller configuration and removed SSL certificate annotation from load balancer settings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 13313df commit a0a97eb

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

scripts/deploy_preview.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ if [[ -n "${RECREATE-}" ]]; then
5555
# execute this db.dropDatabase() from the k8s cluster because there's network restrictions on Atlas cluster.
5656
# The \$ is used to escape the $ character in the APPSMITH_DB_URL environment variable so it's interpolated inside the kubectl exec command.
5757
kubectl exec "$pod_name" -n "$NAMESPACE" -- bash -c "mongosh \$APPSMITH_DB_URL --eval 'db.dropDatabase()'"
58-
kubectl exec "$pod_name" -n "$NAMESPACE" -- bash -c "rm -rf /appsmith-stacks/*"
58+
kubectl exec "$pod_name" -n "$NAMESPACE" -- bash -c "supervisorctl stop all && rm -rf /appsmith-stacks/*"
5959
kubectl delete ns "$NAMESPACE" || true
6060
kubectl patch pv "$NAMESPACE-appsmith" -p '{"metadata":{"finalizers":null}}' || true
6161
kubectl delete pv "$NAMESPACE-appsmith" --grace-period=0 --force || true
@@ -103,10 +103,9 @@ helm upgrade -i "$CHARTNAME" "appsmith-ee/$HELMCHART" -n "$NAMESPACE" --create-n
103103
--set postgresql.enabled=false \
104104
--set mongodb.enabled=false \
105105
--set ingress.enabled=true \
106-
--set "ingress.annotations.service\.beta\.kubernetes\.io/aws-load-balancer-ssl-cert=$AWS_RELEASE_CERT" \
107106
--set "ingress.hosts[0].host=$DOMAINNAME, ingress.hosts[0].paths[0].path=/, ingress.hosts[0].paths[0].pathType=Prefix" \
108107
--set autoupdate.enabled=false \
109-
--set ingress.className="nginx" \
108+
--set ingress.className="traefik" \
110109
--set persistence.efs.enabled=true \
111110
--set persistence.efs.driver="efs.csi.aws.com" \
112111
--set persistence.storageClass="efs-sc" \

0 commit comments

Comments
 (0)