fix(create-cli): return no plugins when none recommended

Author: hanna-skryl

packages/create-cli/src/lib/setup/codegen.ts

@@ -68,7 +68,9 @@ function addPlugins(
   plugins: PluginCodegenResult[],
 ): void {
   if (plugins.length === 0) {
-    builder.addLine('plugins: [],', 1);
+    builder.addLine('plugins: [', 1);
+    builder.addLine('// TODO: register some plugins', 2);
+    builder.addLine('],', 1);
   } else {
     builder.addLine('plugins: [', 1);
     builder.addLines(

packages/create-cli/src/lib/setup/codegen.unit.test.ts

@@ -3,12 +3,14 @@ import type { PluginCodegenResult } from './types.js';
 
 describe('generateConfigSource', () => {
   describe('TypeScript format', () => {
-    it('should generate config with empty plugins array', () => {
+    it('should generate config with TODO placeholder when no plugins provided', () => {
       expect(generateConfigSource([], 'ts')).toMatchInlineSnapshot(`
         "import type { CoreConfig } from '@code-pushup/models';
 
         export default {
-          plugins: [],
+          plugins: [
+            // TODO: register some plugins
+          ],
         } satisfies CoreConfig;
         "
       `);
@@ -104,11 +106,13 @@ describe('generateConfigSource', () => {
   });
 
   describe('JavaScript format', () => {
-    it('should generate JS config with empty plugins array', () => {
+    it('should generate JS config with TODO placeholder when no plugins provided', () => {
       expect(generateConfigSource([], 'js')).toMatchInlineSnapshot(`
         "/** @type {import('@code-pushup/models').CoreConfig} */
         export default {
-          plugins: [],
+          plugins: [
+            // TODO: register some plugins
+          ],
         };
         "
       `);

packages/create-cli/src/lib/setup/prompts.ts

@@ -10,8 +10,8 @@ import type {
  * Resolves which plugins to include in the generated config.
  *
  * Resolution order (first match wins):
- * 1. `--plugins` CLI argument: comma-separated slugs, validated against available bindings
- * 2. `--yes` flag: recommended plugins (or all if none recommended)
+ * 1. `--plugins`: comma-separated slugs, validated against available bindings
+ * 2. `--yes`: recommended plugins
  * 3. Interactive: checkbox prompt with recommended plugins pre-checked
  */
 export async function promptPluginSelection(
@@ -28,9 +28,7 @@ export async function promptPluginSelection(
   }
   const recommended = await detectRecommended(bindings, targetDir);
   if (cliArgs.yes) {
-    return recommended.size > 0
-      ? bindings.filter(({ slug }) => recommended.has(slug))
-      : bindings;
+    return bindings.filter(({ slug }) => recommended.has(slug));
   }
   const selected = await checkbox({
     message: 'Plugins to include:',

packages/create-cli/src/lib/setup/prompts.unit.test.ts

@@ -154,10 +154,10 @@ describe('promptPluginSelection', () => {
       expect(result[0]).toHaveProperty('slug', 'eslint');
     });
 
-    it('should return all plugins when none are recommended', async () => {
+    it('should return no plugins when none are recommended', async () => {
       await expect(
         promptPluginSelection(bindings, '/test', { yes: true }),
-      ).resolves.toStrictEqual(bindings);
+      ).resolves.toBeArrayOfSize(0);
     });
   });
 

packages/create-cli/src/lib/setup/wizard.int.test.ts

@@ -18,6 +18,7 @@ const TEST_BINDINGS: PluginSetupBinding[] = [
     slug: 'alpha',
     title: 'Alpha Plugin',
     packageName: '@code-pushup/alpha-plugin',
+    isRecommended: () => Promise.resolve(true),
     prompts: [
       {
         key: 'alpha.path',
@@ -43,6 +44,7 @@ const TEST_BINDINGS: PluginSetupBinding[] = [
     slug: 'beta',
     title: 'Beta Plugin',
     packageName: '@code-pushup/beta-plugin',
+    isRecommended: () => Promise.resolve(true),
     generateConfig: () => ({
       imports: [
         {

packages/create-cli/src/lib/setup/wizard.unit.test.ts

@@ -15,6 +15,7 @@ const TEST_BINDING: PluginSetupBinding = {
   slug: 'test-plugin',
   title: 'Test Plugin',
   packageName: '@code-pushup/test-plugin',
+  isRecommended: () => Promise.resolve(true),
   generateConfig: () => ({
     imports: [
       {
@@ -72,7 +73,7 @@ describe('runSetupWizard', () => {
       expect(logger.info).toHaveBeenCalledWith('Dry run — no files written.');
     });
 
-    it('should generate empty config with no bindings', async () => {
+    it('should generate config with TODO placeholder when no bindings provided', async () => {
       await runSetupWizard([], {
         yes: true,
         'target-dir': MEMFS_VOLUME,
@@ -83,7 +84,9 @@ describe('runSetupWizard', () => {
         "import type { CoreConfig } from '@code-pushup/models';
 
         export default {
-          plugins: [],
+          plugins: [
+            // TODO: register some plugins
+          ],
         } satisfies CoreConfig;
         "
       `);