Skip to content

Commit dfeecab

Browse files
committed
fix(plugin-eslint): cleanup runner config removal
1 parent e93232f commit dfeecab

File tree

4 files changed

+2
-193
lines changed

4 files changed

+2
-193
lines changed

packages/plugin-eslint/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
"dependencies": {
4141
"@code-pushup/utils": "0.74.0",
4242
"@code-pushup/models": "0.74.0",
43-
"yargs": "^17.7.2",
4443
"zod": "^4.0.5"
4544
},
4645
"peerDependencies": {

packages/plugin-eslint/src/bin.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/plugin-eslint/src/lib/runner.int.test.ts

Lines changed: 0 additions & 105 deletions
This file was deleted.

packages/plugin-eslint/src/lib/runner/index.ts

Lines changed: 2 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -1,88 +1,16 @@
1-
import { writeFile } from 'node:fs/promises';
2-
import path from 'node:path';
31
import type {
42
Audit,
53
AuditOutput,
64
AuditOutputs,
75
PersistConfig,
86
PluginArtifactOptions,
9-
RunnerConfig,
10-
RunnerFilesPaths,
117
RunnerFunction,
128
} from '@code-pushup/models';
13-
import {
14-
asyncSequential,
15-
createRunnerFiles,
16-
ensureDirectoryExists,
17-
filePathToCliArg,
18-
objectToCliArgs,
19-
readJsonFile,
20-
ui,
21-
} from '@code-pushup/utils';
9+
import { asyncSequential, ui } from '@code-pushup/utils';
2210
import type { ESLintPluginRunnerConfig, ESLintTarget } from '../config.js';
2311
import { lint } from './lint.js';
2412
import { lintResultsToAudits, mergeLinterOutputs } from './transform.js';
25-
import { loadArtifacts } from './utils';
26-
27-
export async function executeRunner({
28-
runnerConfigPath,
29-
runnerOutputPath,
30-
persistOutputDir,
31-
}: RunnerFilesPaths & { persistOutputDir: string }): Promise<void> {
32-
const { slugs, targets } =
33-
await readJsonFile<ESLintPluginRunnerConfig>(runnerConfigPath);
34-
35-
ui().logger.log(`ESLint plugin executing ${targets.length} lint targets`);
36-
37-
const linterOutputs = await asyncSequential(
38-
targets.map(target => ({
39-
...target,
40-
outputDir: persistOutputDir,
41-
})),
42-
lint,
43-
);
44-
const lintResults = mergeLinterOutputs(linterOutputs);
45-
const failedAudits = lintResultsToAudits(lintResults);
46-
47-
const audits = slugs.map(
48-
(slug): AuditOutput =>
49-
failedAudits.find(audit => audit.slug === slug) ?? {
50-
slug,
51-
score: 1,
52-
value: 0,
53-
displayValue: 'passed',
54-
details: { issues: [] },
55-
},
56-
);
57-
58-
await ensureDirectoryExists(path.dirname(runnerOutputPath));
59-
await writeFile(runnerOutputPath, JSON.stringify(audits));
60-
}
61-
62-
export async function createRunnerConfig(
63-
scriptPath: string,
64-
audits: Audit[],
65-
targets: ESLintTarget[],
66-
): Promise<RunnerConfig> {
67-
const config: ESLintPluginRunnerConfig = {
68-
targets,
69-
slugs: audits.map(audit => audit.slug),
70-
};
71-
const { runnerConfigPath, runnerOutputPath } = await createRunnerFiles(
72-
'eslint',
73-
JSON.stringify(config),
74-
);
75-
76-
return {
77-
command: 'node',
78-
args: [
79-
filePathToCliArg(scriptPath),
80-
...objectToCliArgs({ runnerConfigPath, runnerOutputPath }),
81-
],
82-
configFile: runnerConfigPath,
83-
outputFile: runnerOutputPath,
84-
};
85-
}
13+
import { loadArtifacts } from './utils.js';
8614

8715
export async function createRunnerFunction(options: {
8816
audits: Audit[];

0 commit comments

Comments
 (0)