refactor: wip

Author: BioPhoton

packages/utils/src/lib/profiler/wal-json-trace.unit.test.ts

@@ -493,19 +493,11 @@ describe('traceEventWalFormat', () => {
       },
     };
 
-    // Start with encoded string
     const initialEncoded = format.codec.encode(originalEvent);
-
-    // First decode
     const firstDecoded = format.codec.decode(initialEncoded);
-
-    // Encode again
     const secondEncoded = format.codec.encode(firstDecoded);
-
-    // Decode again
     const secondDecoded = format.codec.decode(secondEncoded);
 
-    // Verify the final decoded event matches the first decoded event
     expect(secondDecoded).toStrictEqual(firstDecoded);
     expect(secondDecoded).toStrictEqual(originalEvent);
   });

packages/utils/src/lib/wal-sharded.int.test.ts

@@ -58,7 +58,6 @@ describe('ShardedWal Integration', () => {
 
     shardedWal.finalize();
 
-    // With filename provided, final file uses the first filename (test-shard-1)
     const finalFile = path.join(
       testDir,
       shardedWal.groupId,
@@ -85,7 +84,6 @@ describe('ShardedWal Integration', () => {
       filename: 'shard-1',
     });
 
-    // Create multiple shards
     for (let i = 1; i <= 5; i++) {
       const shard = shardedWal.shard();
       shard.open();
@@ -95,7 +93,6 @@ describe('ShardedWal Integration', () => {
 
     shardedWal.finalize();
 
-    // With filename provided, final file uses the first filename (shard-1)
     const finalFile = path.join(
       testDir,
       shardedWal.groupId,
@@ -140,7 +137,6 @@ describe('ShardedWal Integration', () => {
 
     shardedWal.finalize();
 
-    // With filename provided, final file uses the filename (test-shard)
     const finalFile = path.join(
       testDir,
       shardedWal.groupId,
@@ -180,23 +176,18 @@ describe('ShardedWal Integration', () => {
 
     shardedWal.finalize();
 
-    // Verify final file exists
-    // With filename provided, final file uses the first filename (shard-1)
     const finalFile = path.join(
       testDir,
       shardedWal.groupId,
       `cleanup-test.shard-1.json`,
     );
     expect(fs.existsSync(finalFile)).toBeTrue();
 
-    // Cleanup should remove shard files (only if coordinator)
     shardedWal.cleanupIfCoordinator();
 
-    // Verify shard files are removed
     const groupDir = path.join(testDir, shardedWal.groupId);
     const files = fs.readdirSync(groupDir);
     expect(files).not.toContain(expect.stringMatching(/cleanup-test.*\.log$/));
-    // Final file should still exist (uses first filename: shard-1)
     expect(files).toContain(`cleanup-test.shard-1.json`);
   });
 
@@ -222,7 +213,6 @@ describe('ShardedWal Integration', () => {
 
     shardedWal.finalize({ version: '2.0', timestamp: Date.now() });
 
-    // With filename provided, final file uses the filename (custom-shard)
     const finalFile = path.join(
       testDir,
       shardedWal.groupId,
@@ -250,7 +240,6 @@ describe('ShardedWal Integration', () => {
       groupId: 'empty-shards',
     });
 
-    // Create group directory but no shards
     const groupDir = path.join(testDir, shardedWal.groupId);
     fs.mkdirSync(groupDir, { recursive: true });
 

packages/utils/src/lib/wal-sharded.unit.test.ts

@@ -318,14 +318,8 @@ describe('ShardedWal', () => {
         format: { baseName: 'test', walExtension: '.log' },
       });
 
-      // Note: This test verifies state transition logic.
-      // Actual cleanup requires coordinator status which is hard to set up in unit tests.
-      // The state transition is tested via cleanupIfCoordinator() behavior.
-      // If instance is coordinator, cleanupIfCoordinator() will clean and set state to 'cleaned'.
-      // If not coordinator, state remains 'active'.
       sw.cleanupIfCoordinator();
 
-      // State depends on coordinator status - we test the logic, not the coordinator setup
       const state = sw.getState();
       expect(['active', 'cleaned']).toContain(state);
     });