fix(plugin-typescript): fix async configureTypescriptPlugin calls

hanna-skryl · claude · hanna-skryl · commit b9c748a0e27a · 2026-01-22T17:44:34.000-05:00
- Change TSCONFIG_PATTERNS from array to Set per unicorn/prefer-set-has
- Add missing await to configureTypescriptPlugin calls in all project
  configs after making the function async

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/packages/ci/code-pushup.config.ts b/packages/ci/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/core/code-pushup.config.ts b/packages/core/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/create-cli/code-pushup.config.ts b/packages/create-cli/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/nx-plugin/code-pushup.config.ts b/packages/nx-plugin/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-axe/code-pushup.config.ts b/packages/plugin-axe/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-coverage/code-pushup.config.ts b/packages/plugin-coverage/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-eslint/code-pushup.config.ts b/packages/plugin-eslint/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-js-packages/code-pushup.config.ts b/packages/plugin-js-packages/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-jsdocs/code-pushup.config.ts b/packages/plugin-jsdocs/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-lighthouse/code-pushup.config.ts b/packages/plugin-lighthouse/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-typescript/code-pushup.config.ts b/packages/plugin-typescript/code-pushup.config.ts
@@ -14,6 +14,6 @@ export default mergeConfigs(
   configureUpload(projectName),
   await configureEslintPlugin(projectName),
   await configureCoveragePlugin(projectName),
-  configureTypescriptPlugin(projectName),
+  await configureTypescriptPlugin(projectName),
   configureJsDocsPlugin(projectName),
 );
diff --git a/packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts b/packages/plugin-typescript/src/lib/nx/tsconfig-paths.ts
@@ -7,12 +7,12 @@ import { formatMetaLog } from '../format.js';
 /**
  * TypeScript config patterns to look for in each project.
  */
-const TSCONFIG_PATTERNS = [
+const TSCONFIG_PATTERNS = new Set([
   'tsconfig.lib.json',
   'tsconfig.spec.json',
   'tsconfig.test.json',
   'tsconfig.app.json',
-];
+]);
 
 /**
  * Resolves the cached project graph for the current Nx workspace.
@@ -46,7 +46,7 @@ async function findTsconfigsInProject(projectRoot: string): Promise<string[]> {
   const absoluteRoot = path.resolve(process.cwd(), projectRoot);
   const files = await readdir(absoluteRoot);
   return files
-    .filter(file => TSCONFIG_PATTERNS.includes(file))
+    .filter(file => TSCONFIG_PATTERNS.has(file))
     .map(file => path.join(projectRoot, file));
 }
 
