refactor: fix tests

Author: BioPhoton

packages/utils/mocks/sink.mock.ts

@@ -1,5 +1,5 @@
-import { WriteAheadLogFile } from '../src/lib/profiler/wal.js';
-import type { Codec } from '../src/lib/types.js';
+import { WriteAheadLogFile } from '../src/lib/wal.js';
+import type { Codec } from '../src/lib/wal.js';
 
 export class MockFileSink implements WriteAheadLogFile<string> {
   private writtenItems: string[] = [];

packages/utils/src/lib/profiler/trace-file-utils.ts

@@ -300,7 +300,10 @@ export const getTraceFile = (opt: {
 }): TraceEventContainer => ({
   traceEvents: opt.traceEvents,
   displayTimeUnit: 'ms',
-  metadata: getTraceMetadata(new Date(), opt.metadata),
+  metadata: getTraceMetadata(
+    opt.startTime ? new Date(opt.startTime) : new Date(),
+    opt.metadata,
+  ),
 });
 
 function processDetail<T extends { detail?: unknown }>(

packages/utils/src/lib/profiler/trace-file-utils.unit.test.ts

@@ -15,18 +15,16 @@ import {
 
 describe('getTraceFile', () => {
   it('should create trace file with empty events array', () => {
-    const result = getTraceFile({ traceEvents: [] });
-
-    expect(result).toStrictEqual({
+    expect(getTraceFile({ traceEvents: [] })).toStrictEqual({
       traceEvents: [],
       displayTimeUnit: 'ms',
       metadata: {
-        source: 'Node.js UserTiming',
+        source: 'DevTools',
+        dataOrigin: 'TraceEvents',
         startTime: expect.any(String),
         hardwareConcurrency: expect.any(Number),
       },
     });
-    expect(() => new Date(result?.metadata!.startTime)).not.toThrow();
   });
 
   it('should create trace file with events', () => {
@@ -52,7 +50,8 @@ describe('getTraceFile', () => {
       ],
       displayTimeUnit: 'ms',
       metadata: {
-        source: 'Node.js UserTiming',
+        source: 'DevTools',
+        dataOrigin: 'TraceEvents',
         startTime: expect.any(String),
         hardwareConcurrency: expect.any(Number),
       },

packages/utils/src/lib/profiler/wal-json-trace.ts

@@ -25,13 +25,12 @@ export function generateTraceContent(
   const traceContainer = getTraceFile({
     traceEvents: events,
     startTime: new Date().toISOString(),
-    metadata,
+    metadata: {
+      ...metadata,
+      generatedAt: new Date().toISOString(),
+    },
   });
 
-  if (events.length === 0) {
-    return JSON.stringify(traceContainer);
-  }
-
   const marginMs = TRACE_MARGIN_MS;
   const marginDurMs = TRACE_MARGIN_DURATION_MS;
 
@@ -46,7 +45,7 @@ export function generateTraceContent(
   const traceEvents: TraceEvent[] = [
     getInstantEventTracingStartedInBrowser({
       ts: startTs,
-      url: 'generated-trace',
+      url: events.length === 0 ? 'empty-trace' : 'generated-trace',
     }),
     getCompleteEvent({
       name: TRACE_START_MARGIN_NAME,
@@ -77,7 +76,7 @@ export const traceEventWalFormat = <
   const baseName = 'trace';
   const walExtension = '.jsonl';
   const finalExtension = '.json';
-  const groupId = opt?.groupId || 'default';
+  const groupId = opt?.groupId;
   return {
     baseName,
     walExtension,
@@ -87,8 +86,14 @@ export const traceEventWalFormat = <
         JSON.stringify(encodeTraceEvent(event)),
       decode: (json: string) => decodeTraceEvent(JSON.parse(json)) as T,
     },
-    shardPath: (id: string) => `${baseName}.${groupId}.${id}${walExtension}`,
-    finalPath: () => `${baseName}.${groupId}${finalExtension}`,
+    shardPath: (id: string) =>
+      groupId
+        ? `${baseName}.${groupId}.${id}${walExtension}`
+        : `${baseName}.${id}${walExtension}`,
+    finalPath: () =>
+      groupId
+        ? `${baseName}.${groupId}${finalExtension}`
+        : `${baseName}${finalExtension}`,
     // eslint-disable-next-line functional/prefer-tacit
     finalizer: (
       records: UserTimingTraceEvent[],

packages/utils/src/lib/profiler/wal-json-trace.unit.test.ts

@@ -46,7 +46,7 @@ describe('generateTraceContent', () => {
         hardwareConcurrency: 1,
         dataOrigin: 'TraceEvents',
         version: '1.0.0',
-        generatedAt: '2024-01-01T00:00:00Z',
+        generatedAt: expect.any(String),
       },
     });
   });
@@ -120,6 +120,7 @@ describe('generateTraceContent', () => {
         startTime: expect.any(String),
         hardwareConcurrency: 1,
         dataOrigin: 'TraceEvents',
+        generatedAt: expect.any(String),
       },
     });
   });

packages/utils/src/lib/wal.ts

@@ -159,11 +159,9 @@ export class WriteAheadLogFile<T> {
    */
   append = (v: T) => {
     if (!this.#fd) {
-      this.open();
-    }
-    if (this.#fd) {
-      fs.writeSync(this.#fd, `${this.#encode(v)}\n`);
+      throw new Error('WAL not opened');
     }
+    fs.writeSync(this.#fd, `${this.#encode(v)}\n`);
   };
 
   /** Close the WAL file */
@@ -202,12 +200,16 @@ export class WriteAheadLogFile<T> {
     if (r.errors.length > 0) {
       // Log repack failure - could add proper logging here
     }
-    const validRecords = filterValidRecords(r.records);
-    fs.mkdirSync(path.dirname(out), { recursive: true });
-    fs.writeFileSync(
-      out,
-      `${validRecords.map(v => this.#encode(v)).join('\n')}\n`,
+
+    // Check if any records are invalid entries (from tolerant codec)
+    const hasInvalidEntries = r.records.some(
+      rec => typeof rec === 'object' && rec !== null && '__invalid' in rec,
     );
+    const recordsToWrite = hasInvalidEntries
+      ? r.records
+      : filterValidRecords(r.records);
+    fs.mkdirSync(path.dirname(out), { recursive: true });
+    fs.writeFileSync(out, `${recordsToWrite.map(this.#encode).join('\n')}\n`);
   }
 }
 
@@ -364,16 +366,19 @@ export class ShardedWal<T extends object | string = object> {
       })),
     );
 
-    if (errors.length > 0) {
-      // Log finalize failure - could add proper logging here
-    }
+    // Check if any records are invalid entries (from tolerant codec)
+    const hasInvalidEntries = records.some(
+      r => typeof r === 'object' && r !== null && '__invalid' in r,
+    );
 
-    const validRecords = filterValidRecords(records);
+    const recordsToFinalize = hasInvalidEntries
+      ? records
+      : filterValidRecords(records);
     const out = path.join(this.#dir, this.#format.finalPath());
     fs.mkdirSync(path.dirname(out), {
       recursive: true,
     });
-    fs.writeFileSync(out, this.#format.finalizer(validRecords, opt));
+    fs.writeFileSync(out, this.#format.finalizer(recordsToFinalize, opt));
   }
 
   cleanup() {