refactor: wip revert

Author: John Doe

packages/nx-plugin/src/executors/cli/executor.ts

@@ -22,37 +22,15 @@ export default async function runAutorunExecutor(
     ...argsObj
   } = terminalAndExecutorOptions;
   const command = bin ? `node` : 'npx';
-
-  // Extract --import flags from NODE_OPTIONS if present (Node.js doesn't allow --import in NODE_OPTIONS)
-  let importArgs: string[] = [];
-  const envVariables = { ...env };
-
-  if (bin && env?.NODE_OPTIONS) {
-    const nodeOptions = env.NODE_OPTIONS;
-    // Match --import <value> or --import=<value>
-    const importMatch = nodeOptions.match(/--import(?:\s+|=)(\S+)/);
-    if (importMatch && importMatch[1]) {
-      importArgs = ['--import', importMatch[1]];
-      // Remove --import flag from NODE_OPTIONS
-      const cleaned = nodeOptions.replace(/--import(?:\s+|=)\S+/g, '').trim();
-      if (cleaned) {
-        envVariables.NODE_OPTIONS = cleaned;
-      } else {
-        delete envVariables.NODE_OPTIONS;
-      }
-    }
-  }
-
   const positionals = [
-    ...importArgs, // Add --import flags before the script when using node
     bin ?? '@code-pushup/cli',
     ...(cliCommand ? [cliCommand] : []),
   ];
   const args = objectToCliArgs(argsObj);
-
-  if (verbose) {
-    envVariables.CP_VERBOSE = 'true';
-  }
+  const envVariables = {
+    ...env,
+    ...(verbose && { CP_VERBOSE: 'true' }),
+  };
 
   const { logger, stringifyError, formatCommand } = await import(
     '@code-pushup/utils'

packages/nx-plugin/src/executors/cli/executor.unit.test.ts

@@ -178,69 +178,4 @@ describe('runAutorunExecutor', () => {
     expect(warnMessage).toContain('DryRun execution of:');
     expect(warnMessage).toContain('npx @code-pushup/cli');
   });
-
-  it('should extract --import from NODE_OPTIONS and pass as direct argument when bin is set', async () => {
-    const { command } = await runAutorunExecutor(
-      {
-        bin: 'packages/cli/src/index.ts',
-        env: {
-          NODE_OPTIONS: '--import tsx',
-          TSX_TSCONFIG_PATH: 'tsconfig.base.json',
-        },
-      },
-      executorContext('utils'),
-    );
-
-    const commandWithoutAnsi = removeColorCodes(command || '');
-    expect(commandWithoutAnsi).toMatch(
-      'node --import tsx packages/cli/src/index.ts',
-    );
-    expect(executeProcessSpy).toHaveBeenCalledWith(
-      expect.objectContaining({
-        command: 'node',
-        args: expect.arrayContaining([
-          '--import',
-          'tsx',
-          'packages/cli/src/index.ts',
-        ]),
-        env: expect.objectContaining({
-          TSX_TSCONFIG_PATH: 'tsconfig.base.json',
-        }),
-      }),
-    );
-    // NODE_OPTIONS should be removed since it only contained --import
-    expect(executeProcessSpy.mock.calls[0]?.[0]?.env).not.toHaveProperty(
-      'NODE_OPTIONS',
-    );
-  });
-
-  it('should preserve other NODE_OPTIONS when extracting --import', async () => {
-    const { command } = await runAutorunExecutor(
-      {
-        bin: 'packages/cli/src/index.ts',
-        env: {
-          NODE_OPTIONS: '--max-old-space-size=4096 --import tsx',
-        },
-      },
-      executorContext('utils'),
-    );
-
-    const commandWithoutAnsi = removeColorCodes(command || '');
-    expect(commandWithoutAnsi).toMatch(
-      'node --import tsx packages/cli/src/index.ts',
-    );
-    expect(executeProcessSpy).toHaveBeenCalledWith(
-      expect.objectContaining({
-        command: 'node',
-        args: expect.arrayContaining([
-          '--import',
-          'tsx',
-          'packages/cli/src/index.ts',
-        ]),
-        env: expect.objectContaining({
-          NODE_OPTIONS: '--max-old-space-size=4096',
-        }),
-      }),
-    );
-  });
 });