refactor: full refactor + add tests

Author: BioPhoton

nx.json

@@ -16,6 +16,7 @@
       "!{projectRoot}/**/?(*.)test.[jt]s?(x)?(.snap)",
       "!{projectRoot}/**/?(*.)mocks.[jt]s?(x)",
       "!{projectRoot}/**/?(*.)mock.[jt]s?(x)",
+      "!{projectRoot}/vite.config.[jt]s",
       "!{projectRoot}/vitest.@(unit|int|e2e).config.[jt]s",
       "!{projectRoot}/dist/**/*",
       "!{projectRoot}/tsconfig.@(test|tools).json",
@@ -363,6 +364,12 @@
         }
       }
     },
+    {
+      "plugin": "@nx/eslint",
+      "options": {
+        "config": "{projectRoot}/eslint.config.js"
+      }
+    },
     {
       "plugin": "@nx/vite/plugin",
       "options": {

package-lock.json

@@ -86,6 +86,7 @@
     "commitizen": "^4.3.1",
     "commitlint-plugin-tense": "^1.0.3",
     "dotenv": "^16.4.5",
+    "eslint-formatter-stylish": "^8.40.0",
     "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-plugin-functional": "^7.1.0",
     "eslint-plugin-import": "2.31.0",

package.json

@@ -25,7 +25,7 @@ async function executeLint({
   patterns,
 }: ESLintTarget): Promise<ESLint.LintResult[]> {
   // running as CLI because ESLint#lintFiles() runs out of memory
-  const { stdout } = await executeProcess({
+  const { stdout, stderr, code } = await executeProcess({
     command: 'npx',
     args: [
       'eslint',
@@ -42,6 +42,12 @@ async function executeLint({
     cwd: process.cwd(),
   });
 
+  if (!stdout.trim()) {
+    throw new Error(
+      `ESLint produced empty output. Exit code: ${code}, STDERR: ${stderr}`,
+    );
+  }
+
   return JSON.parse(stdout) as ESLint.LintResult[];
 }
 

packages/plugin-eslint/src/lib/runner/lint.ts

@@ -1,4 +1,4 @@
-# ESLint Multi-Format Formatter
+# ESLint Multiple-Formats Formatter
 
 The ESLint plugin uses a custom formatter that supports multiple output formats and destinations simultaneously.
 
@@ -14,7 +14,7 @@ Use the `ESLINT_FORMATTER_CONFIG` environment variable to configure the formatte
   "filename": "eslint-report", // Optional: Base filename without extension (default: 'eslint-report')
   "formats": ["json"], // Optional: Array of format names for file output (default: ['json'])
   "terminal": "stylish", // Optional: Format for terminal output (default: 'stylish')
-  "verbose": true // Optional: Enable verbose logging (default: false)
+  "verbose": true, // Optional: Enable verbose logging (default: false)
 }
 ```
 

tools/eslint-multi-format/README.md …int-formatter-multiple-formats/README.mdtools/eslint-multi-format/README.md renamed to tools/eslint-formatter-multiple-formats/README.md tools/eslint-multi-format/README.md renamed to tools/eslint-formatter-multiple-formats/README.md

@@ -1,17 +1,20 @@
 {
-  "name": "eslint-formatter-multi-format",
+  "name": "eslint-formatter-multiple-formats",
   "version": "0.0.1",
   "private": false,
   "type": "module",
-  "main": "./index.js",
-  "types": "./index.d.ts",
+  "main": "./src/index.js",
+  "types": "./src/index.d.ts",
+  "engines": {
+    "node": ">=17.0.0"
+  },
   "description": "ESLint formatter that supports multiple output formats and destinations simultaneously",
   "author": "Michael Hladky",
   "license": "MIT",
   "repository": {
     "type": "git",
     "url": "https://github.com/code-pushup/cli.git",
-    "directory": "tools/eslint-multi-format"
+    "directory": "tools/eslint-formatter-multiple-formats"
   },
   "keywords": [
     "eslint",
@@ -22,14 +25,14 @@
     "linting"
   ],
   "files": [
-    "index.js",
-    "index.d.ts",
-    "lib/",
-    "README.md",
-    "package.json"
+    "src/*",
+    "README.md"
   ],
-  "engines": {
-    "node": ">=18.0.0"
+  "publishConfig": {
+    "access": "public"
+  },
+  "dependencies": {
+    "eslint-formatter-stylish": "^8.40.0"
   },
   "peerDependencies": {
     "eslint": "^8.0.0 || ^9.0.0"

…ols/eslint-multi-format/eslint.config.js …matter-multiple-formats/eslint.config.jstools/eslint-multi-format/eslint.config.js renamed to tools/eslint-formatter-multiple-formats/eslint.config.js tools/eslint-multi-format/eslint.config.js renamed to tools/eslint-formatter-multiple-formats/eslint.config.js

@@ -1,12 +1,13 @@
 {
-  "name": "eslint-multi-formatter",
+  "name": "eslint-formatter-multiple-formats",
   "$schema": "../../node_modules/nx/schemas/project-schema.json",
   "sourceRoot": "tools/eslint-multi-format/src",
   "projectType": "library",
   "tags": [],
   "// targets": "to see all targets run: nx show project eslint-multi-format with option --web for humans and --json for AI",
   "targets": {
     "lint": {},
+    "unit-test": {},
     "build": {
       "executor": "@nx/vite:build",
       "outputs": ["{options.outputPath}"],

tools/eslint-multi-format/package.json …-formatter-multiple-formats/package.jsontools/eslint-multi-format/package.json renamed to tools/eslint-formatter-multiple-formats/package.json tools/eslint-multi-format/package.json renamed to tools/eslint-formatter-multiple-formats/package.json

@@ -2,8 +2,8 @@ import type { ESLint } from 'eslint';
 import path from 'node:path';
 import type { EslintFormat, FormatterConfig } from './types.js';
 import {
+  formatTerminalOutput,
   findConfigFromEnv as getConfigFromEnv,
-  getTerminalOutput,
   persistEslintReports,
 } from './utils.js';
 
@@ -58,8 +58,6 @@ export default function multipleFormats(
     verbose = false,
   } = config;
 
-  const terminalOutput = getTerminalOutput(terminal, results);
-
   try {
     persistEslintReports(formats, results, {
       outputDir,
@@ -72,5 +70,5 @@ export default function multipleFormats(
     }
   }
 
-  return terminalOutput;
+  return formatTerminalOutput(terminal, results);
 }