From b04719d99f0443baf6a8c598a0b4cf7c744542a0 Mon Sep 17 00:00:00 2001 From: DMarinhoCodacy Date: Tue, 26 May 2026 16:40:12 +0100 Subject: [PATCH 1/4] fix regex for the rule codacy.generic.sql.lookup-type-without-language-or-apps-fnd --- docs/codacy-rules.yaml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/docs/codacy-rules.yaml b/docs/codacy-rules.yaml index 73dd5ac..8d908bb 100644 --- a/docs/codacy-rules.yaml +++ b/docs/codacy-rules.yaml @@ -322,9 +322,13 @@ rules: languages: - generic patterns: - - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\bapps\\.fnd_lookup_values\\b" - - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blookup_type\\b" - - pattern-not-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blanguage\\b" + - pattern-either: + # Scenario 1: lookup_type WITHOUT language + - patterns: + - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blookup_type\\b" + - pattern-not-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blanguage\\b" + # Scenario 2: ANY use of apps.fnd_lookup_values + - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\bapps\\.fnd_lookup_values\\b" paths: include: - "*.sql" From 92c1002557d8d4c0ec4c6fb57b25578f56952757 Mon Sep 17 00:00:00 2001 From: DMarinhoCodacy Date: Tue, 26 May 2026 18:07:52 +0100 Subject: [PATCH 2/4] fix regex --- docs/codacy-rules.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/codacy-rules.yaml b/docs/codacy-rules.yaml index 8d908bb..44933e8 100644 --- a/docs/codacy-rules.yaml +++ b/docs/codacy-rules.yaml @@ -323,12 +323,12 @@ rules: - generic patterns: - pattern-either: - # Scenario 1: lookup_type WITHOUT language - - patterns: - - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blookup_type\\b" - - pattern-not-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\blanguage\\b" + # Scenario 1: lookup_type WITHOUT an active language clause + - pattern-regex: >- + (?is)(?:^|;)(?!(?:[^;]*?\n)*?[ \t]*(?:(?!--|/\*)[^\n;])*?\blanguage\b)[^;]*?\blookup_type\b # Scenario 2: ANY use of apps.fnd_lookup_values - - pattern-regex: "(?im)^(?:(?!--|/\\*)[^\\n])*\\bapps\\.fnd_lookup_values\\b" + - pattern-regex: >- + (?im)^(?:(?!--|/\*)[^\n])*\bapps\.fnd_lookup_values\b paths: include: - "*.sql" From 2d23454ffa5db66802113861703e5951ec1b554c Mon Sep 17 00:00:00 2001 From: DMarinhoCodacy Date: Tue, 26 May 2026 18:36:26 +0100 Subject: [PATCH 3/4] tweak regex --- docs/codacy-rules.yaml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/codacy-rules.yaml b/docs/codacy-rules.yaml index 44933e8..134954b 100644 --- a/docs/codacy-rules.yaml +++ b/docs/codacy-rules.yaml @@ -323,12 +323,10 @@ rules: - generic patterns: - pattern-either: - # Scenario 1: lookup_type WITHOUT an active language clause - pattern-regex: >- - (?is)(?:^|;)(?!(?:[^;]*?\n)*?[ \t]*(?:(?!--|/\*)[^\n;])*?\blanguage\b)[^;]*?\blookup_type\b - # Scenario 2: ANY use of apps.fnd_lookup_values + (?is)(?:^|(?<=;))(?!(?:[^;]*?\n)*?[ \t]*(?:(?!--|/\*)[^\n;])*?\blanguage\b)[^;]*?\K\blookup_type\b - pattern-regex: >- - (?im)^(?:(?!--|/\*)[^\n])*\bapps\.fnd_lookup_values\b + (?im)^[ \t]*\K(?:(?!--|/\*)[^\n])*\bapps\.fnd_lookup_values\b paths: include: - "*.sql" From d642571c4837130bbe14450ecc84332c60a4edf8 Mon Sep 17 00:00:00 2001 From: DMarinhoCodacy Date: Tue, 26 May 2026 18:41:34 +0100 Subject: [PATCH 4/4] fix ai reviewer issue --- docs/codacy-rules.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/codacy-rules.yaml b/docs/codacy-rules.yaml index 134954b..77fa0e4 100644 --- a/docs/codacy-rules.yaml +++ b/docs/codacy-rules.yaml @@ -324,7 +324,7 @@ rules: patterns: - pattern-either: - pattern-regex: >- - (?is)(?:^|(?<=;))(?!(?:[^;]*?\n)*?[ \t]*(?:(?!--|/\*)[^\n;])*?\blanguage\b)[^;]*?\K\blookup_type\b + (?is)(?:^|(?<=;))(?!(?:[^;\n]*\n)*?[ \t]*(?:(?!--|/\*)[^\n;])*?\blanguage\b)[^;]*?\K\blookup_type\b - pattern-regex: >- (?im)^[ \t]*\K(?:(?!--|/\*)[^\n])*\bapps\.fnd_lookup_values\b paths: