Skip to content

Commit cec7fa4

Browse files
IvanBorislavovDimitrovikasarov
authored andcommitted
Fix unmodifiable collection issue
1 parent a638480 commit cec7fa4

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

multiapps-controller-persistence/src/main/java/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ private int removeBlobsByFilter(Predicate<? super Blob> filter) {
205205
.toList();
206206
List<Boolean> deletedBlobsResults = new ArrayList<>();
207207
if (!blobIds.isEmpty()) {
208-
deletedBlobsResults = deleteBlobs(blobIds);
208+
deletedBlobsResults.addAll(deleteBlobs(blobIds));
209209
}
210210

211211
deletedBlobsResults.removeIf(Boolean.FALSE::equals);

multiapps-controller-persistence/src/test/java/org/cloudfoundry/multiapps/controller/persistence/services/GcpObjectStoreFileStorageTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.util.List;
88
import java.util.Map;
99
import java.util.UUID;
10-
1110
import com.google.cloud.storage.Blob;
1211
import com.google.cloud.storage.BlobId;
1312
import com.google.cloud.storage.BlobInfo;
@@ -17,7 +16,6 @@
1716
import org.junit.jupiter.api.AfterEach;
1817
import org.junit.jupiter.api.BeforeEach;
1918
import org.springframework.http.MediaType;
20-
2119
import static org.junit.jupiter.api.Assertions.assertEquals;
2220
import static org.junit.jupiter.api.Assertions.assertNull;
2321

@@ -43,7 +41,7 @@ protected List<Boolean> deleteBlobs(List<BlobId> blobIds) {
4341
for (BlobId blobId : blobIds) {
4442
deletedBlobsResults.add(storage.delete(blobId));
4543
}
46-
return deletedBlobsResults;
44+
return List.copyOf(deletedBlobsResults);
4745
}
4846
};
4947
spaceId = UUID.randomUUID()

0 commit comments

Comments
 (0)