Increase user agent suffix length to 128 characters

Author: theghost5800

README.md

@@ -71,7 +71,7 @@ The configuration of the MultiApps CF plugin is done via env variables. The foll
 For example, with a 100MB MTAR the minimum value for this environment variable would be 2, and for a 400MB MTAR it would be 8. Finally, the minimum value cannot grow over 50, so with a 4GB MTAR, the minimum value would be 50 and not 80.
 * `MULTIAPPS_UPLOAD_CHUNKS_SEQUENTIALLY=<BOOLEAN>` - By default, MTAR chunks are uploaded in parallel for better performance. In case of a bad internet connection, the option to upload them sequentially will lessen network load.
 * `MULTIAPPS_DISABLE_UPLOAD_PROGRESS_BAR=<BOOLEAN>` - By default, the file upload shows a progress bar. In case of CI/CD systems where console text escaping isn't supported, the bar can be disabled to reduce unnecessary logs.
-* `MULTIAPPS_USER_AGENT_SUFFIX=<STRING>` - Allows customization of the User-Agent header sent with all HTTP requests. The value will be appended to the standard User-Agent string format: "Multiapps-CF-plugin/{version} ({operating system version}) {golang builder version} {custom_value}". Only alphanumeric characters, spaces, hyphens, dots, and underscores are allowed. Maximum length is 64 characters; longer values will be truncated. Dangerous characters (control characters, colons, semicolons) are automatically removed for security. This can be useful for tracking requests from specific environments or CI/CD systems.
+* `MULTIAPPS_USER_AGENT_SUFFIX=<STRING>` - Allows customization of the User-Agent header sent with all HTTP requests. The value will be appended to the standard User-Agent string format: "Multiapps-CF-plugin/{version} ({operating system version}) {golang builder version} {custom_value}". Only alphanumeric characters, spaces, hyphens, dots, and underscores are allowed. Maximum length is 128 characters; longer values will be truncated. Dangerous characters (control characters, colons, semicolons) are automatically removed for security. This can be useful for tracking requests from specific environments or CI/CD systems.
 
 # How to contribute
 * [Did you find a bug?](CONTRIBUTING.md#did-you-find-a-bug)

util/env_configuration_help.go

@@ -5,7 +5,7 @@ const BaseEnvHelpText = `
 ENVIRONMENT:
    DEBUG=1                                         Enables the logging of HTTP requests in STDOUT and STDERR.
    MULTIAPPS_CONTROLLER_URL=<URL>                  Overrides the default deploy-service.<system-domain> with a custom URL.
-   MULTIAPPS_USER_AGENT_SUFFIX=<STRING>            Appends custom text to User-Agent header. Only alphanumeric, spaces, hyphens, dots, underscores allowed. Max 64 chars, excess truncated.
+   MULTIAPPS_USER_AGENT_SUFFIX=<STRING>            Appends custom text to User-Agent header. Only alphanumeric, spaces, hyphens, dots, underscores allowed. Max 128 chars, excess truncated.
 `
 const UploadEnvHelpText = BaseEnvHelpText + `
    MULTIAPPS_UPLOAD_CHUNK_SIZE=<POSITIVE_INTEGER>  Configures chunk size (in MB) for MTAR upload.

util/user_agent_builder.go

@@ -9,7 +9,7 @@ import (
 )
 
 // Limit for MULTIAPPS_USER_AGENT_SUFFIX
-const maxSuffixLength = 64
+const maxSuffixLength = 128
 
 // pluginVersion stores the version set from the main package
 var pluginVersion string = "0.0.0"

util/user_agent_builder_test.go

@@ -150,12 +150,12 @@ var _ = Describe("UserAgentBuilder", func() {
 			})
 
 			It("should truncate excessively long values", func() {
-				longValue := strings.Repeat("a", 600) // 600 chars, should be truncated to 64
+				longValue := strings.Repeat("a", 600) // 600 chars, should be truncated to 128
 				os.Setenv("MULTIAPPS_USER_AGENT_SUFFIX", longValue)
 				userAgent := util.BuildUserAgent()
 
 				// Should contain truncated suffix
-				expectedSuffix := strings.Repeat("a", 64)
+				expectedSuffix := strings.Repeat("a", 128)
 				Expect(userAgent).To(ContainSubstring(expectedSuffix))
 				// But not the full original value
 				Expect(userAgent).ToNot(ContainSubstring(longValue))
@@ -165,7 +165,7 @@ var _ = Describe("UserAgentBuilder", func() {
 		Context("with maximum length suffix", func() {
 			BeforeEach(func() {
 				util.SetPluginVersion("1.0.0")
-				longSuffix := strings.Repeat("a", 64)
+				longSuffix := strings.Repeat("a", 128)
 				os.Setenv("MULTIAPPS_USER_AGENT_SUFFIX", longSuffix)
 			})