From e8e952674e2c768ee1ea47ef7c893e563e1626b7 Mon Sep 17 00:00:00 2001 From: Konboi Date: Mon, 30 Jun 2025 17:11:25 +0900 Subject: [PATCH 1/3] updated to collect messges more --- launchable/test_runners/robot.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/launchable/test_runners/robot.py b/launchable/test_runners/robot.py index 81f7f6efc..5f15723e8 100644 --- a/launchable/test_runners/robot.py +++ b/launchable/test_runners/robot.py @@ -40,11 +40,14 @@ def parse_suite(suite: ET.Element): "time": str(duration.total_seconds()) if duration is not None else '0', }) + if status_node.text is not None: + out = ET.SubElement(testcase, 'system-out') + out.text = status_node.text + if status == "FAIL": failure = ET.SubElement(testcase, 'failure') - - msg = test.find('kw/msg') - failure.text = msg.text if msg is not None else '' + msgs = test.findall('kw/msg') + failure.text = "\n".join(msg.text for msg in msgs) if msgs else '' if status == "NOT_RUN" or nested_status == 'NOT_RUN': skipped = ET.SubElement(testcase, "skipped") # noqa: F841 From 2638e142058c0d8896ff7e3189f1c585d3bba3e7 Mon Sep 17 00:00:00 2001 From: Konboi Date: Mon, 30 Jun 2025 17:14:33 +0900 Subject: [PATCH 2/3] updated requests --- .../robot/record_test_executed_only_one_file_result.json | 6 +++--- tests/data/robot/record_test_result.json | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/data/robot/record_test_executed_only_one_file_result.json b/tests/data/robot/record_test_executed_only_one_file_result.json index 2211ea60e..5d3f191f8 100644 --- a/tests/data/robot/record_test_executed_only_one_file_result.json +++ b/tests/data/robot/record_test_executed_only_one_file_result.json @@ -14,7 +14,7 @@ ], "duration": 0.001, "status": 0, - "stdout": "", + "stdout": "0 != -1", "stderr": "0 != -1", "data": null }, @@ -58,6 +58,6 @@ "testRunner": "robot", "group": "", "noBuild": false, - "flavors": [], - "testSuite": "" + "testSuite": "", + "flavors": {} } diff --git a/tests/data/robot/record_test_result.json b/tests/data/robot/record_test_result.json index e9a327c36..325740346 100644 --- a/tests/data/robot/record_test_result.json +++ b/tests/data/robot/record_test_result.json @@ -14,7 +14,7 @@ ], "duration": 0.002, "status": 0, - "stdout": "", + "stdout": "0 != -1", "stderr": "0 != -1", "data": null }, @@ -68,7 +68,7 @@ ], "duration": 0.001, "status": 0, - "stdout": "", + "stdout": "0 != -1", "stderr": "0 != -1", "data": null }, @@ -112,6 +112,6 @@ "testRunner": "robot", "group": "", "noBuild": false, - "flavors": [], - "testSuite": "" + "testSuite": "", + "flavors": {} } From ffe175355cc8e19814facea438c6690b94df06b2 Mon Sep 17 00:00:00 2001 From: Konboi Date: Mon, 30 Jun 2025 17:28:26 +0900 Subject: [PATCH 3/3] fix type check --- launchable/test_runners/robot.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/launchable/test_runners/robot.py b/launchable/test_runners/robot.py index 5f15723e8..f2ba130f2 100644 --- a/launchable/test_runners/robot.py +++ b/launchable/test_runners/robot.py @@ -40,14 +40,18 @@ def parse_suite(suite: ET.Element): "time": str(duration.total_seconds()) if duration is not None else '0', }) - if status_node.text is not None: + if status_node is not None: out = ET.SubElement(testcase, 'system-out') - out.text = status_node.text + out.text = status_node.text if status_node.text else '' if status == "FAIL": failure = ET.SubElement(testcase, 'failure') - msgs = test.findall('kw/msg') - failure.text = "\n".join(msg.text for msg in msgs) if msgs else '' + + msgs = [] + for msg in test.findall('kw/msg'): + if msg is not None and msg.text is not None: + msgs.append(msg.text) + failure.text = "\n".join(msgs) if msgs else '' if status == "NOT_RUN" or nested_status == 'NOT_RUN': skipped = ET.SubElement(testcase, "skipped") # noqa: F841