CLJS-1120: analyze-deps does not appear to work when analyzing analysis caches

cljs.analyzer/no-warn:
    * incorrectly bound *analyze-deps* to false

cljs.analyzer/analyze-file:
    * only take cache path if :cache-analysis true

cljs.build-api-tests:
    * fix broken tests that assuemd *analyze-deps* false

cljs.compiler/compile-file:
    * no need to cache analysis, will be handled by dependency analysis

Author: dnolen

src/clj/cljs/analyzer.clj

@@ -246,8 +246,7 @@
 
 (defmacro no-warn [& body]
   (let [no-warnings (zipmap (keys *cljs-warnings*) (repeat false))]
-    `(binding [*cljs-warnings* ~no-warnings
-               *analyze-deps* false]
+    `(binding [*cljs-warnings* ~no-warnings]
        ~@body)))
 
 (defmacro all-warn [& body]
@@ -2049,8 +2048,7 @@ argument, which the reader will use in any emitted errors."
                path (if (instance? File res)
                       (.getPath ^File res)
                       (.getPath ^URL res))
-               cache (when (or (= (:ns ns-info) 'cljs.core)
-                               (:cache-analysis opts))
+               cache (when (:cache-analysis opts)
                        (cache-file res ns-info output-dir))]
            (when-not (get-in @env/*compiler* [::namespaces (:ns ns-info)])
              (if (or (not cache)

src/clj/cljs/compiler.clj

@@ -1125,10 +1125,7 @@
                           {:recompile (into recompile (ana/ns-dependents ns))
                            :visited   (conj visited ns)})))
                     ret))
-                (do
-                  (when-not (contains? (::ana/namespaces @env/*compiler*) ns)
-                    (with-core-cljs opts (fn [] (ana/analyze-file src-file opts))))
-                  ns-info)))
+                ns-info))
             (catch Exception e
               (throw (ex-info (str "failed compiling file:" src) {:file src} e))))
           (throw (java.io.FileNotFoundException. (str "The file " src " does not exist."))))))))

test/clj/cljs/build_api_tests.clj

@@ -42,7 +42,8 @@
 
 ;; basic
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
@@ -51,20 +52,23 @@
 
 ;; linear
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
         '(ns foo.core)))))
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
         '(ns bar.core
            (:require [foo.core :as foo]))))))
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
@@ -73,20 +77,23 @@
 
 ;; graph
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
         '(ns graph.foo.core)))))
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env
         '(ns graph.bar.core
            (:require [graph.foo.core :as foo]))))))
 
-(binding [ana/*cljs-ns* 'cljs.user]
+(binding [ana/*cljs-ns* 'cljs.user
+          ana/*analyze-deps* false]
   (env/with-compiler-env test-cenv
     (ana/no-warn
       (ana/analyze test-env