Skip to content

Commit c8d18ae

Browse files
authored
fix: portable ckb is not available on windows (#347)
1 parent 659966d commit c8d18ae

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/node/install.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,8 @@ function buildCKBGithubReleasePackageName(version: string, opt: { os?: string; a
178178
const os = opt.os || getOS();
179179
const arch = opt.arch || getArch();
180180

181-
if (isPortable()) {
181+
if (isPortable() && os !== 'pc-windows-msvc') {
182+
// portable binary is not available for windows
182183
return `ckb_v${version}_${arch}-${os}-portable`;
183184
} else {
184185
return `ckb_v${version}_${arch}-${os}`;
@@ -193,7 +194,8 @@ function buildCKBGithubReleasePackageNameWithExtension(
193194
const arch = opt.arch || getArch();
194195
const extension = opt.ext || getExtension();
195196

196-
if (isPortable()) {
197+
if (isPortable() && os !== 'pc-windows-msvc') {
198+
// portable binary is not available for windows
197199
return `ckb_v${version}_${arch}-${os}-portable.${extension}`;
198200
} else {
199201
return `ckb_v${version}_${arch}-${os}.${extension}`;

0 commit comments

Comments
 (0)