-
Notifications
You must be signed in to change notification settings - Fork 32
Closed
Description
While I can see that the PR from shouldAddinputs is merged into master, it is not released under canary nor latest. Feel free to check out 0.0.0-canary-20250710073207 and 1.9.0.
Conversely it is present in the older canary: 0.0.0-canary-20250613163026
At this point, I'd like to suggest a couple more ideas for Transaction.completeFee options:
- Instead of
shouldAddInputs?: boolean;how aboutaddInputs?: "default" | "disable";? (Follows your suggestion of no boolean flags) source?: "chain" | "local", this is very evident as it is currently hard-coded tolocal.
Maybe also consider adding this source?: "chain" | "local" to findCells in Client, we can agree that this missing option is creating quite a bit of unnecessary code duplication in libraries depending on CCC.
Love and Peace, Phroi %18
Metadata
Metadata
Assignees
Labels
No labels